Skip to content

Complete unhandled remote notifications - #26166

Merged
crazytonyli merged 1 commit into
wordpress-mobile:trunkfrom
mvanhorn:fix/25657-push-notification-completion
Oct 27, 2026
Merged

crazytonyli merged 1 commit into
wordpress-mobile:trunkfrom
mvanhorn:fix/25657-push-notification-completion

Conversation

@mvanhorn

Copy link
Copy Markdown
Contributor

Description

Some remote notifications leave iOS waiting for a completion callback even though the app has no work to perform. Repeated missed callbacks can reduce future background push delivery. The badge-reset guard returned without calling the completion handler for missing, invalid, or badge-reset types. The dispatch loop also left the callback uncalled when every handler declined the notification.

Ignored and unhandled notifications now complete with .noData. The dispatch loop returns when a handler accepts a notification, preserving that handler's result without invoking the fallback callback. Regression tests cover ignored payloads, repeated unhandled deliveries, authentication results, and nil completion handlers.

Fixes #25657

Testing instructions

swift build completed successfully; the regression tests were not run.

Ignored and unhandled notifications now complete with .noData. The
dispatch loop returns when a handler accepts a notification, preserving
that handler's result without invoking the fallback callback. Regression
tests cover ignored payloads, repeated unhandled deliveries,
authentication results, and nil completion handlers.

Fixes wordpress-mobile#25657
@crazytonyli
crazytonyli enabled auto-merge October 27, 2026 00:01
@wpmobilebot

Copy link
Copy Markdown
Contributor
App Icon📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress
ConfigurationRelease-Alpha
Build Number35243
VersionPR #26166
Bundle IDorg.wordpress.alpha
Commit0b52df4
Installation URL70divitdpkln0
Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

@wpmobilebot

Copy link
Copy Markdown
Contributor
App Icon📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack
ConfigurationRelease-Alpha
Build Number35243
VersionPR #26166
Bundle IDcom.jetpack.alpha
Commit0b52df4
Installation URL6r8la9ndqbj00
Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

@crazytonyli
crazytonyli added this pull request to the merge queue Oct 27, 2026
Merged via the queue into wordpress-mobile:trunk with commit 7624faf Oct 27, 2026
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

handleNotification can drop the remote-notification completion handler, throttling background push delivery

3 participants