Skip to content

Fix notification permission primer host controller leak - #26045

Merged
crazytonyli merged 1 commit into
trunkfrom
task/fix-notification-primer-leak
Sep 22, 2026
Merged

crazytonyli merged 1 commit into
trunkfrom
task/fix-notification-primer-leak

Conversation

@crazytonyli

Copy link
Copy Markdown
Contributor

No description provided.

The alert's action builder captured the host controller strongly. AlertView stores that builder and the builder's result becomes the controller's root view, so the primer was never released once shown. Capture the controller weakly in the builder instead.
@dangermattic

Copy link
Copy Markdown
Collaborator
1 Message
📖 This PR is still a Draft: some checks will be skipped.

Generated by 🚫 Danger

@wpmobilebot

Copy link
Copy Markdown
Contributor
App Icon📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress
ConfigurationRelease-Alpha
Build Number34529
VersionPR #26045
Bundle IDorg.wordpress.alpha
Commit0ec563b
Installation URL6gekh5dl6g2q8
Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

@wpmobilebot

Copy link
Copy Markdown
Contributor
App Icon📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack
ConfigurationRelease-Alpha
Build Number34529
VersionPR #26045
Bundle IDcom.jetpack.alpha
Commit0ec563b
Installation URL5o8f6doblvu98
Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

@crazytonyli crazytonyli added this to the 27.4 milestone Sep 21, 2026
@crazytonyli
crazytonyli marked this pull request as ready for review September 21, 2026 06:33
@crazytonyli
crazytonyli added this pull request to the merge queue Sep 22, 2026
Merged via the queue into trunk with commit 8f2daf7 Sep 22, 2026
29 of 30 checks passed
@crazytonyli
crazytonyli deleted the task/fix-notification-primer-leak branch September 22, 2026 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants