Skip to content

Enable editor help menu for eligible users - #17008

Merged
dcalhoun merged 6 commits into
developfrom
update/enable-editor-help-menu
Aug 19, 2021
Merged

dcalhoun merged 6 commits into
developfrom
update/enable-editor-help-menu

Conversation

@dcalhoun

@dcalhoun dcalhoun commented Aug 11, 2021 •

Copy link
Copy Markdown
Member

Related PRs

To test: See WordPress/gutenberg#34018.

Regression Notes

  1. Potential unintended areas of impact
    Changes to the feature flag could disrupted existing flagged features.
  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    Tested a few of the feature flag feature to ensure they functioned as expected.
  3. What automated tests I added (or what prevented me from doing so)
    Decided automated tests in this repository were not valuable for this Gutenberg-centric change.

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Now that the feature is complete, we enable the help menu button if the
user account is within the cohort.
@dcalhoun dcalhoun added [Type] Enhancement Gutenberg Editing and display of Gutenberg blocks. labels Aug 11, 2021
@dcalhoun dcalhoun self-assigned this Aug 11, 2021
@peril-wordpress-mobile

peril-wordpress-mobile Bot commented Aug 11, 2021 •

Copy link
Copy Markdown

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

@peril-wordpress-mobile

peril-wordpress-mobile Bot commented Aug 11, 2021 •

Copy link
Copy Markdown

You can trigger an installable build for these changes by visiting CircleCI here.

@dcalhoun dcalhoun added this to the 18.1 milestone Aug 11, 2021
@dcalhoun
dcalhoun marked this pull request as ready for review August 11, 2021 21:25
@dcalhoun
dcalhoun requested a review from jhnstn August 11, 2021 21:26

@jhnstn jhnstn left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've run through the test steps in the companion Gutenberg PR and everything works as expected 👍

@dcalhoun
dcalhoun enabled auto-merge August 19, 2021 04:57
@dcalhoun
dcalhoun merged commit c849d01 into develop Aug 19, 2021
@dcalhoun
dcalhoun deleted the update/enable-editor-help-menu branch August 19, 2021 05:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Gutenberg Editing and display of Gutenberg blocks.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants