Skip to content

[Gutenberg - Test] Audio block local url parsing fix - #16589

Closed
jd-alexander wants to merge 1 commit into
developfrom
gutenberg/audio-block-url-parsing-issue
Closed

jd-alexander wants to merge 1 commit into
developfrom
gutenberg/audio-block-url-parsing-issue

Conversation

@jd-alexander

@jd-alexander jd-alexander commented May 27, 2021 •

Copy link
Copy Markdown
Contributor

Gutenberg Mobile PR wordpress-mobile/gutenberg-mobile#3558
Gutenberg PR WordPress/gutenberg#32291
WP Android PR wordpress-mobile/WordPress-Android#14738

Description

The purpose of this PR is to verify that the media upload flows for the Audio block are all working as expected. A recent refactoring of a component URL parsing component caused the Choose from device to be broken since it didn't support local URIs of files in internal/external storage.

Testing

Prerequisite

Utilize a paid plan as the PR enabling the free plan support has not been merged in as yet.

Other apps

  1. Create a new post.
  2. Add the Audio block.
  3. Select "Other apps"
  4. Select an audio file from your device.
  5. Verify that no crash occurs and the Audio Player UI is being shown and the filename has been rendered.

WordPress Media Library

  1. Create a new post.
  2. Add the Audio block.
  3. Select "WordPress Media Library".
  4. Select an audio file from your device.
  5. Verify that the Audio Player UI is being shown and the filename has been rendered.

Insert from URL

  1. Create a new post.
  2. Add the Audio block.
  3. Select "Insert from URL".
  4. Paste or type a sample audio link like http://www.mp3.com/file.mp3.
  5. Verify that the Audio Player UI is being shown and the filename has been rendered.

Regression Notes

  1. Potential unintended areas of impact
    The main area of impact would be the flows that are tested above as they both utilize the logic that was modified therefore properly testing them should mitigate the risk of merging in changes that cause side effects.

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    To test the areas of impact, the media upload flows were utilized.

  3. What automated tests I added (or what prevented me from doing so)
    From a test standpoint, the gutenberg now has support for the URIs that both iOS and Android provide, so the fact that the URL parsing tests are passing gives us confidence that the app will behave as expected.

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@peril-wordpress-mobile

peril-wordpress-mobile Bot commented May 27, 2021 •

Copy link
Copy Markdown

You can test the changes on this Pull Request by downloading it from AppCenter here with build number: 49096. IPA is available here. If you need access to this, you can ask a maintainer to add you.

@peril-wordpress-mobile

peril-wordpress-mobile Bot commented May 27, 2021 •

Copy link
Copy Markdown

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

@peril-wordpress-mobile

peril-wordpress-mobile Bot commented May 27, 2021 •

Copy link
Copy Markdown
Warnings
⚠️ PR is missing at least one label.

Generated by 🚫 dangerJS

@dcalhoun dcalhoun left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jd-alexander

Copy link
Copy Markdown
Contributor Author

Thanks, David. Closing these PRs since they are only for testing.

@jd-alexander
jd-alexander deleted the gutenberg/audio-block-url-parsing-issue branch May 27, 2021 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants