Repository navigation
[Gutenberg - Test] Audio block local url parsing fix - #16589
Closed
jd-alexander wants to merge 1 commit into
Closed
jd-alexander wants to merge 1 commit into
jd-alexander wants to merge 1 commit into
Conversation
|
You can trigger optional UI/connected tests for these changes by visiting CircleCI here. |
Generated by 🚫 dangerJS |
dcalhoun
approved these changes
May 27, 2021
dcalhoun
left a comment
Member
There was a problem hiding this comment.
LGTM. Reviewed via WordPress/gutenberg#32291 (review).
Contributor
Author
|
Thanks, David. Closing these PRs since they are only for testing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Gutenberg MobilePR wordpress-mobile/gutenberg-mobile#3558GutenbergPR WordPress/gutenberg#32291WP AndroidPR wordpress-mobile/WordPress-Android#14738Description
The purpose of this PR is to verify that the media upload flows for the Audio block are all working as expected. A recent refactoring of a component URL parsing component caused the
Choose from deviceto be broken since it didn't support local URIs of files in internal/external storage.Testing
Prerequisite
Utilize a paid plan as the PR enabling the free plan support has not been merged in as yet.
Other apps
WordPress Media Library
Insert from URL
http://www.mp3.com/file.mp3.Regression Notes
Potential unintended areas of impact
The main area of impact would be the flows that are tested above as they both utilize the logic that was modified therefore properly testing them should mitigate the risk of merging in changes that cause side effects.
What I did to test those areas of impact (or what existing automated tests I relied on)
To test the areas of impact, the media upload flows were utilized.
What automated tests I added (or what prevented me from doing so)
From a test standpoint, the
gutenbergnow has support for the URIs that both iOS and Android provide, so the fact that the URL parsing tests are passing gives us confidence that the app will behave as expected.PR submission checklist:
RELEASE-NOTES.txtif necessary.