Skip to content

Testing Gutenberg after merging navigation feature - #13082

Closed
lukewalczak wants to merge 2 commits into
developfrom
test/navigation-and-appender
Closed

lukewalczak wants to merge 2 commits into
developfrom
test/navigation-and-appender

Conversation

@lukewalczak

Copy link
Copy Markdown
Contributor

Fixes #

To test:

PR submission checklist:

  • I have considered adding unit tests where possible.

  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@lukewalczak lukewalczak added [Status] DO NOT MERGE Gutenberg Editing and display of Gutenberg blocks. labels Dec 12, 2019
@peril-wordpress-mobile

peril-wordpress-mobile Bot commented Dec 12, 2019 •

Copy link
Copy Markdown
Warnings
⚠️ This PR is tagged with 'DO NOT MERGE'.
⚠️ PR is not assigned to a milestone.

Generated by 🚫 dangerJS

@peril-wordpress-mobile

peril-wordpress-mobile Bot commented Dec 12, 2019 •

Copy link
Copy Markdown

You can test the changes on this Pull Request by downloading it from AppCenter here with build number: 18683. IPA is available here. If you need access to this, you can ask a maintainer to add you.

@pinarol

pinarol commented Dec 12, 2019

Copy link
Copy Markdown
Contributor

@iamthomasbishop Could you try to install the app with the peril link provided by this PR? It demonstrates how it looks after the merge of inner block enhancements. There are some things that look a bit odd to me but I can't be sure if that's intended. If you find some issues we'll need to fix those before holidays so the earlier we spot the better.

Screen Shot 2019-12-12 at 15 23 25

Screen Shot 2019-12-12 at 15 25 27

@iamthomasbishop

Copy link
Copy Markdown

That's right, @pinarol – the Inline Toolbar does look like it has some extra spacing – looks like not just additional bottom spacing, but also and left/right spacing (16px?):

image

@iamthomasbishop

iamthomasbishop commented Dec 12, 2019 •

Copy link
Copy Markdown

It is so great to see this in action – a long time coming! 😄 I have some quick feedback.

EDIT: I've re-ordered based on priority and labeled those that I would consider blockers as such.

Blockers

  • As discussed earlier, there is an issue w/ the spacing of the Inline Toolbar.

  • The margins/padding on the Columns block look a bit broken (screenshot). Unsupported, I know, but I tried adding one on web 😄

  • It looks like there is extra padding applied on the Media & Text block now? (screenshot)

Non-blockers

  • When I add any type of RichText block within an empty Group, the input isn't focused right away – this felt odd, and it doesn't happen on a non-empty Group block.

  • Can we hide the Floating Toolbar on unsupported blocks like the Columns block, so that they don't say "unrecognized"? (screenshot)

  • I know we had discussed the Appender spacing, but I think we might want to align to the same visual keyline as the child block borders (screenshot)

  • Is it possible to remove the opacity-change effect when the breadcrumbs are tapped? Because nothing happens when I tap it (which is fine until we have the doc navigator), it might feel like a bug to users.


That's all I've got right now, I am going to give it another spin tomorrow morning 😄 Thanks for all of the hard work on this thus far!

@iamthomasbishop

Copy link
Copy Markdown

@pinarol @lukewalczak Updated my last comment to include which I think are blockers vs. non-blockers and roughly sorted by priority.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Gutenberg Editing and display of Gutenberg blocks.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants