Repository navigation
Show Gutenberg title after it appears - #10568
Merged
Merged
Conversation
This fixes an issue where the toolbar wouldn't be immediately visible
11 tasks done
pinarol
approved these changes
Nov 30, 2018
pinarol
left a comment
Contributor
There was a problem hiding this comment.
as we talked on slack, removing the viewDidAppear because it'll cause to focus move to title whenever we come back to the editor page from other pages like preview, post settings etc.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes an issue where the toolbar wouldn't be immediately visible when creating a new post. This sets the focus on the title bar after the editor has appeared, so the gutenberg view gets laid out correctly.
To test: