Skip to content

Show Gutenberg title after it appears - #10568

Merged
pinarol merged 2 commits into
developfrom
issue/gb-title-focus
Nov 30, 2018
Merged

pinarol merged 2 commits into
developfrom
issue/gb-title-focus

Conversation

@koke

@koke koke commented Nov 29, 2018

Copy link
Copy Markdown
Member

This fixes an issue where the toolbar wouldn't be immediately visible when creating a new post. This sets the focus on the title bar after the editor has appeared, so the gutenberg view gets laid out correctly.

To test:

  • Create a new Gutenberg post
  • The focus should be in the title field
  • The toolbar should be visible

This fixes an issue where the toolbar wouldn't be immediately visible
@koke koke added the Gutenberg Editing and display of Gutenberg blocks. label Nov 29, 2018
@koke koke added this to the 11.4 milestone Nov 29, 2018
@koke
koke requested a review from pinarol November 29, 2018 14:22
@koke koke mentioned this pull request Nov 29, 2018
11 tasks done

@pinarol pinarol left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as we talked on slack, removing the viewDidAppear because it'll cause to focus move to title whenever we come back to the editor page from other pages like preview, post settings etc.

@pinarol
pinarol merged commit 81e1f6e into develop Nov 30, 2018
@pinarol
pinarol deleted the issue/gb-title-focus branch December 3, 2018 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Gutenberg Editing and display of Gutenberg blocks.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants