Repository navigation
Update compileSdkVersion (from 29 to 31) for All Modules - #16891
Conversation
PS: No changes were needed to make this update possible. This is the default and root level 'compileSdkVersion' that all modules should be pointing to from now. This is done in order to make sure that there is no discrepancy in relation to compile SDK versions being different for different modules. Also, and just as an FYI, for 'minSdkVersion' and 'targetSdkVersion' this is already the case.
PS: No changes were needed to make this update possible. This is the default and root level 'compileSdkVersion' that all modules should be pointing to from now. This is done in order to make sure that there is no discrepancy in relation to compile SDK versions being different for different modules. Also, and just as an FYI, for 'minSdkVersion' and 'targetSdkVersion' this is already the case.
PS: No changes were needed to make this update possible. This is the default and root level 'compileSdkVersion' that all modules should be pointing to from now. This is done in order to make sure that there is no discrepancy in relation to compile SDK versions being different for different modules. Also, and just as an FYI, for 'minSdkVersion' and 'targetSdkVersion' this is already the case.
PS: No changes were needed to make this update possible. This is the default and root level 'compileSdkVersion' that all modules should be pointing to from now. This is done in order to make sure that there is no discrepancy in relation to compile SDK versions being different for different modules. Also, and just as an FYI, for 'minSdkVersion' and 'targetSdkVersion' this is already the case.
|
You can trigger optional UI/connected tests for these changes by visiting CircleCI here. |
|
You can test the WordPress changes on this Pull Request by downloading an installable build (wordpress-installable-build-pr16891-2e7b516.apk), or scanning this QR code: |
|
You can test the Jetpack changes on this Pull Request by downloading an installable build (jetpack-installable-build-pr16891-2e7b516.apk), or scanning this QR code: |
|
I am shameless pinging you again on this PR review @oguzkocer as I am not sure if you missed it by now. 😊 If you don't have the capacity to review this PR at this point, or even next week, just let me know and I'll make sure to assign it to a WPAndroid engineer instead. 🙏 PS: This is not urgent, not at all, so don't feel the need to get it done asap. I just pinged you to make sure that you are aware of it. 🙇 |
oguzkocer
left a comment
There was a problem hiding this comment.
@ParaskP7 I was sick when you opened this PR and it looks like I missed it when I got back. Sorry about that!
P.S: Similar to an earlier feedback I've shared, in my opinion 4 commits where each commit change a single line for the exact same thing (compileSdkVersion) is counter productive.
Hey, please don't apologize @oguzkocer , not at all, I was totally aware of that, I was just making sure that this was still on your radar for exactly this reason. This wasn't urgent so it could have waited anyway. Thank you for doing the review and actually merging it to
First of all, thank you so much for sharing your feedback on my commits and structure, please keep them coming, they are totally welcome as I am always trying to become better and more productive when it comes to that! ❤️ Secondly, and please take this will me be curious about it and trying to understand the feedback more so that trying to fight it, so, are 4 commit counter productive for (a) the author, (b) the reviewer or (c) the engineers afterwards (who are going to come back to this and read the change)?
Lastly, let me explain, without trying to convince you of anything, how I end up coming to that result, 4 commits instead of 1. When I started with that work, I didn't want to just change all I didn't want to keep that change (commit) hanging for two reasons:
As you can see from my above process, I didn't just create 4 commits and tested the end results, I was testing as I was progressing, which each commit going in, per module. Does this makes sense to you? Or would you have tested just the end result, just like the reviewer would do afterwards anyway, in the hope that everything is working as expected with the final change on all 4 modules and no further changes will be required afterwards anyway? 🤔 |
Parent #16562
This PR updates the
compileSdkVersion(from29to31) for all modules. No changes were needed to make this update possible.compileSdkVersion = 31is the default and root levelcompileSdkVersionthat all modules should be pointing to from now. This is done in order to make sure that there is no discrepancy in relation to compile SDK versions being different for different modules. Also, and just as an FYI, forminSdkVersionandtargetSdkVersionthis is already the case.Obviously, the main
WordPressmodule was already pointing tocompileSdkVersion = 31, but so was theimage-editormodule. As such, the below 4 remaining modules got updated in the end:mocksanalyticsnetworkingeditorTo test:
mocksmodule, you could run theUI Testsand verify correctness.analyticsmodule, you could launch the app and verify that you see the🔵 Tracked:logs in logcat.networkingmodule, you could launch the app and verify thatReader->DISCOVERtab works as expected (pull-to-refresh,scrolling and pagination, etc).editormodule, you could launch the app and add a newPost/Storypost andSitepage.Regression Notes
App is not compiling as expected.
See
To testsection above.N/A
PR submission checklist:
RELEASE-NOTES.txtif necessary.