Skip to content

Remove Unnecessary Kotlin StdLib Dependency from All Modules - #16830

Merged
ParaskP7 merged 1 commit into
trunkfrom
build/remove-kotlin-stdlib-dependencies
Jun 28, 2022
Merged

ParaskP7 merged 1 commit into
trunkfrom
build/remove-kotlin-stdlib-dependencies

Conversation

@ParaskP7

@ParaskP7 ParaskP7 commented Jun 27, 2022 •

Copy link
Copy Markdown
Contributor

Parent #16562
Relates to #15314 (see comment)

This PR removes the unnecessary Kotlin stdlib standard library dependency from all modules. From now on, and as per the recommendation, the version of the standard library used should be the same as the version of the Kotlin Gradle plugin.


To test:

  • Smoke test the app.

Regression Notes

  1. Potential unintended areas of impact

N/A

  1. What I did to test those areas of impact (or what existing automated tests I relied on)

See To test section above.

  1. What automated tests I added (or what prevented me from doing so)

PR submission checklist:

N/A


  • I have completed the Regression Notes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@ParaskP7 ParaskP7 added this to the 20.3 milestone Jun 27, 2022
@ParaskP7
ParaskP7 requested a review from oguzkocer June 27, 2022 15:44
@ParaskP7 ParaskP7 self-assigned this Jun 27, 2022
@peril-wordpress-mobile

Copy link
Copy Markdown

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

@wpmobilebot

Copy link
Copy Markdown
Contributor

Found 1 violations:

The PR caused the following dependency changes:

-+--- com.automattic:about:0.0.5
-|    +--- org.jetbrains.kotlin:kotlin-parcelize-runtime:1.5.31 -> 1.6.10
-|    |    \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.10
-|    |         +--- org.jetbrains:annotations:13.0
-|    |         \--- org.jetbrains.kotlin:kotlin-stdlib-common:1.6.10
-|    \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.5.31 -> 1.6.10
-|         +--- org.jetbrains.kotlin:kotlin-stdlib:1.6.10 (*)
-|         \--- org.jetbrains.kotlin:kotlin-stdlib-jdk7:1.6.10
-|              \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.10 (*)
++--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.10
+|    +--- org.jetbrains.kotlin:kotlin-stdlib:1.6.10
+|    |    +--- org.jetbrains:annotations:13.0
+|    |    \--- org.jetbrains.kotlin:kotlin-stdlib-common:1.6.10
+|    \--- org.jetbrains.kotlin:kotlin-stdlib-jdk7:1.6.10
+|         \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.10 (*)
++--- com.automattic:about:0.0.5
+|    +--- org.jetbrains.kotlin:kotlin-parcelize-runtime:1.5.31 -> 1.6.10
+|    |    \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.10 (*)
+|    \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.5.31 -> 1.6.10 (*)
 +--- project :libs:image-editor
-|    \--- org.jetbrains.kotlin:kotlin-stdlib-jdk7:1.6.10 (*)
+|    \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.10 (*)
-+--- org.jetbrains.kotlin:kotlin-stdlib-jdk7:1.6.10 (*)
 \--- project :libs:editor
-     +--- org.jetbrains.kotlin:kotlin-stdlib-jdk7:1.6.10 (*)
-     \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.10 (*)
+     \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.10 (*)

Please review and act accordingly

@wpmobilebot

Copy link
Copy Markdown
Contributor
You can test the WordPress changes on this Pull Request by downloading an installable build (wordpress-installable-build-pr16830-f67d135.apk), or scanning this QR code:

@wpmobilebot

Copy link
Copy Markdown
Contributor
You can test the Jetpack changes on this Pull Request by downloading an installable build (jetpack-installable-build-pr16830-f67d135.apk), or scanning this QR code:

@ovitrif ovitrif mentioned this pull request Jun 28, 2022
3 tasks done

@oguzkocer oguzkocer left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ParaskP7 Thank you for addressing this!

@ParaskP7
ParaskP7 merged commit 5442cb4 into trunk Jun 28, 2022
@ParaskP7
ParaskP7 deleted the build/remove-kotlin-stdlib-dependencies branch June 28, 2022 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants