Repository navigation
Remove Unnecessary Kotlin StdLib Dependency from All Modules - #16830
Merged
Merged
Conversation
|
You can trigger optional UI/connected tests for these changes by visiting CircleCI here. |
22 of 23 tasks
Contributor
|
Found 1 violations: The PR caused the following dependency changes:-+--- com.automattic:about:0.0.5
-| +--- org.jetbrains.kotlin:kotlin-parcelize-runtime:1.5.31 -> 1.6.10
-| | \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.10
-| | +--- org.jetbrains:annotations:13.0
-| | \--- org.jetbrains.kotlin:kotlin-stdlib-common:1.6.10
-| \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.5.31 -> 1.6.10
-| +--- org.jetbrains.kotlin:kotlin-stdlib:1.6.10 (*)
-| \--- org.jetbrains.kotlin:kotlin-stdlib-jdk7:1.6.10
-| \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.10 (*)
++--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.10
+| +--- org.jetbrains.kotlin:kotlin-stdlib:1.6.10
+| | +--- org.jetbrains:annotations:13.0
+| | \--- org.jetbrains.kotlin:kotlin-stdlib-common:1.6.10
+| \--- org.jetbrains.kotlin:kotlin-stdlib-jdk7:1.6.10
+| \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.10 (*)
++--- com.automattic:about:0.0.5
+| +--- org.jetbrains.kotlin:kotlin-parcelize-runtime:1.5.31 -> 1.6.10
+| | \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.10 (*)
+| \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.5.31 -> 1.6.10 (*)
+--- project :libs:image-editor
-| \--- org.jetbrains.kotlin:kotlin-stdlib-jdk7:1.6.10 (*)
+| \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.10 (*)
-+--- org.jetbrains.kotlin:kotlin-stdlib-jdk7:1.6.10 (*)
\--- project :libs:editor
- +--- org.jetbrains.kotlin:kotlin-stdlib-jdk7:1.6.10 (*)
- \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.10 (*)
+ \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.10 (*)
Please review and act accordingly
|
Contributor
|
You can test the WordPress changes on this Pull Request by downloading an installable build (wordpress-installable-build-pr16830-f67d135.apk), or scanning this QR code: |
Contributor
|
You can test the Jetpack changes on this Pull Request by downloading an installable build (jetpack-installable-build-pr16830-f67d135.apk), or scanning this QR code: |
3 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Parent #16562
Relates to #15314 (see comment)
This PR removes the unnecessary Kotlin
stdlibstandard library dependency from all modules. From now on, and as per the recommendation, the version of the standard library used should be the same as the version of the Kotlin Gradle plugin.To test:
Regression Notes
N/A
See
To testsection above.PR submission checklist:
N/A
RELEASE-NOTES.txtif necessary.