Repository navigation
[Modules Restructuring] Restructure Analytics Module #16744
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
771b76b
Build: Remove unused analytics specific gradle properties example file
ParaskP7 c3ade3c
Build: Remove unnecessary git ignore file from analytics module
ParaskP7 4ebe98e
Build: Remove sub-root related gradle files from analytics module
ParaskP7 6e421a8
Docs: Update readme for analytics module
ParaskP7 206995f
Build: Remove unnecessary wordpress analytics module level
ParaskP7 af667ac
Docs: Update library with module on analytics module readme description
ParaskP7 039001f
Merge branch 'trunk' of github.com:wordpress-mobile/WordPress-Android…
ParaskP7 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,13 +1,3 @@ | ||
| # WordPressCom-Analytics-Android | ||
| # Analytics | ||
|
|
||
| Library for handling Analytics tracking in WordPress Android. | ||
|
|
||
| Part of the [WordPress-Android] project. | ||
|
|
||
| [WordPress-Android]: https://github.com/wordpress-mobile/WordPress-Android | ||
|
|
||
| ## Publish it to bintray | ||
|
|
||
| ```shell | ||
| $ ./gradlew assemble publishToMavenLocal bintrayUpload -PbintrayUser=FIXME -PbintrayKey=FIXME -PdryRun=false | ||
| ``` | ||
| Module for handling Analytics tracking. |
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,31 @@ | ||
| plugins { | ||
| id "com.android.library" | ||
| } | ||
|
|
||
| repositories { | ||
| maven { | ||
| url "https://a8c-libs.s3.amazonaws.com/android" | ||
| content { | ||
| includeGroup "org.wordpress" | ||
| includeGroup "com.automattic" | ||
| includeGroup "com.automattic.tracks" | ||
| } | ||
| } | ||
| } | ||
|
|
||
| dependencies { | ||
| implementation "com.automattic:Automattic-Tracks-Android:$tracksVersion" | ||
| implementation "org.wordpress:utils:$wordPressUtilsVersion" | ||
|
|
||
| lintChecks 'org.wordpress:lint:1.1.0' | ||
| } | ||
|
|
||
| android { | ||
| compileSdkVersion 29 | ||
|
|
||
| defaultConfig { | ||
| minSdkVersion rootProject.minSdkVersion | ||
| targetSdkVersion rootProject.targetSdkVersion | ||
| } | ||
| } | ||
|
|
This file was deleted.
Oops, something went wrong.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we use
:libs:WordPressAnalyticsinstead, so it's consistent with:libs:WordPressProcessors,:libs:WordPressAnnotationsetc?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👋 @oguzkocer and thank you so much for the suggestion! 🙏
I actually considered that too while doing this change, but I ended up in favor of the plain
analyticsnaming instead ofWordPressAnalyticsfor the below two main reasons:WordPressrepo, as such, having to add theWordPressprefix to every module seems unnecessary.WordPressapp is also building theJetpackapp. As such, it might be better to remove the wordWordPressfrom every module so that to avoid anyJetpackrelated naming confusion.To that end, I was thinking to also rename the
WordPressProcessorsandWordPressAnnotationsmodules to plainprocessorsandannotationsin order to have every module naming consistent from now on.In the end, I am planning to end up with the below module names:
WordPressAnalytics)WordPressEditor)editor/example)ImageEditor)WordPressMocks)WordPressNetworking)WordPressAnnotations)WordPressProcessors)Let me know what you think. 🤔 🙇
PS: You will also notice the
editor-example:There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good to me. As long as we are consistent, I don't mind either naming and your reasoning makes sense to me for going with the shorter version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, yes, consistency matters, thanks for giving me the 👍 on it @oguzkocer ! 🙇