Skip to content

App Data Coverage: Add tracking in WPWebView - #16450

Merged
ashiagr merged 7 commits into
trunkfrom
issue/16343-app-date-coverage-webview
May 2, 2022
Merged

ashiagr merged 7 commits into
trunkfrom
issue/16343-app-date-coverage-webview

Conversation

@zwarm

@zwarm zwarm commented May 1, 2022

Copy link
Copy Markdown
Contributor

Parent #16343

This PR adds tracking to the following actions of WPWebViewActivity:

  • Displayed
  • Dismissed
  • Open in external browser tapped
  • Reload tapped
  • Navigated back
  • Navigated forward
  • Share button tapped
  • Device preview changed

To test:

  • Launch app and login in (if needed)
  • Navigate to My Site tab
  • Tap on the site URL in the Site Header to launch the web view
  • Verify the logs contain: 🔵 Tracked: webview_displayed
  • Tap the reload icon in the upper right hand corner of the view
  • Verify the logs contain: 🔵 Tracked: webview_reload_tapped
  • Tap the Share icon on the bottom navigation bar
  • Verify the logs contain: 🔵 Tracked: webview_share_tapped
  • Tap the Globe icon on the bottom navigation bar
  • Verify the logs contain: 🔵 Tracked: webview_open_in_browser_tapped
  • Navigate back into the app from viewing in the external browser
  • Tap the Device icon on the bottom navigation bar and select a different device type
  • Verify the logs contain: 🔵 Tracked: webview_preview_device_changed, Properties: {"selected_option_name":"VALUE"}
  • Navigate to a page within your site within the webview to enable to back/forward navigation button on the bottom bar
  • Tap the Navigate back button
  • Verify the logs contain: 🔵 Tracked: webview_navigated_back
  • Tap the Navigation forward button
  • Verify the logs contain: 🔵 Tracked: webview_navigated_forward
  • Return the My Site tab using the back arrow or back button
  • Verify the logs contain: 🔵 Tracked: webview_dismissed

Regression Notes

  1. Potential unintended areas of impact
    Only added track events

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    Manual Testing

  3. What automated tests I added (or what prevented me from doing so)
    Updated WPWebViewViewModelTest to account for tracker

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@zwarm zwarm added this to the 19.9 milestone May 1, 2022
@zwarm
zwarm requested a review from ashiagr May 1, 2022 15:57
@peril-wordpress-mobile

Copy link
Copy Markdown

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

@zwarm zwarm mentioned this pull request May 1, 2022
18 tasks done
@zwarm zwarm self-assigned this May 1, 2022
@peril-wordpress-mobile

Copy link
Copy Markdown

You can test the changes on this Pull Request by downloading the APKs:

@ashiagr ashiagr left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All events are tracked as described. Also, code changes look good to me. 👍

:shipit:

@ashiagr ashiagr modified the milestones: 19.9, 19.8 May 2, 2022
@ashiagr
ashiagr self-requested a review May 2, 2022 07:04
@ashiagr
ashiagr merged commit 10c7afa into trunk May 2, 2022
@ashiagr
ashiagr deleted the issue/16343-app-date-coverage-webview branch May 2, 2022 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants