Skip to content

App Data Coverage: add more tracking for page list - #16411

Merged
zwarm merged 1 commit into
trunkfrom
issue/16343-app-data-coverage-page-list
Apr 27, 2022
Merged

zwarm merged 1 commit into
trunkfrom
issue/16343-app-data-coverage-page-list

Conversation

@zwarm

@zwarm zwarm commented Apr 26, 2022

Copy link
Copy Markdown
Contributor

Parent #16343

This PR adds tracking events for the remainder of the menu item actions on the Pages List.

To test:

  • Launch the app
  • Navigate to Pages -> Published tab
  • Tap on the "more" menu icon on the non-home page page item within the Published Tab
  • Tap on Set as Homepage
  • ✅ Verify the logs contains: 🔵 Tracked: site_pages_options_pressed, Properties: {"option_name":"set_homepage","blog_id":186945892,"is_jetpack":false,"site_type":"blog"}
  • Tap on the "more" menu icon of the same page
  • Tap on Set as Posts Page
  • ✅ Verify the logs contains: 🔵 Tracked: site_pages_options_pressed, Properties: {"option_name":"set_posts_page","blog_id":186945892,"is_jetpack":false,"site_type":"blog"}
  • Navigate to the Trashed tab
  • If you don't have a trashed post, create a new post or move a published post to trash
  • Tap the "more" menu icon on a trashed page
  • Tap Delete Permanently
  • ✅ Verify the logs contains: Tracked: site_pages_options_pressed, Properties: {"option_name":"delete_permanently","blog_id":186945892,"is_jetpack":false,"site_type":"blog","default_tab_experiment":"site_menu"}
  • Navigate to Drafts Tab
  • If you have no pages in draft tabs, copy an existing page to create another and choose save instead of Publish Now
  • Tap on the "more" menu icon on the drafts page
  • Tap "Publish Now"
  • ✅ Verify the logs contains: 🔵 Tracked: site_pages_tabs_pressed, Properties: {"tab_name":"published","blog_id":186945892,"is_jetpack":false,"site_type":"blog"}

Regression Notes

  1. Potential unintended areas of impact
    Only added track events

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    Manual testing

  3. What automated tests I added (or what prevented me from doing so)
    N/A

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@zwarm zwarm added this to the 19.8 milestone Apr 26, 2022
@zwarm
zwarm requested a review from ashiagr April 26, 2022 17:02
@zwarm zwarm self-assigned this Apr 26, 2022
@peril-wordpress-mobile

Copy link
Copy Markdown

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

@zwarm zwarm mentioned this pull request Apr 26, 2022
18 tasks done
@peril-wordpress-mobile

Copy link
Copy Markdown

You can test the changes on this Pull Request by downloading the APKs:

@ashiagr ashiagr self-assigned this Apr 27, 2022

@ashiagr ashiagr left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All events are tracked as described. 👍

@zwarm
zwarm merged commit 55f2718 into trunk Apr 27, 2022
@zwarm
zwarm deleted the issue/16343-app-data-coverage-page-list branch April 27, 2022 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants