Skip to content

App Data Coverage: add more tracking to the Change Username flow - #16379

Merged
ashiagr merged 7 commits into
trunkfrom
issue/16343-change-username-flow-tracking
Apr 22, 2022
Merged

ashiagr merged 7 commits into
trunkfrom
issue/16343-change-username-flow-tracking

Conversation

@zwarm

@zwarm zwarm commented Apr 21, 2022

Copy link
Copy Markdown
Contributor

Parent #16343

Description
This PR adds 3 new tracking events to the change username flow:

  • When the view is displayed
  • When the view is dismissed
  • When a user performs a search; including the number of searches perfomred

Since this username change feature is available within the signup flow + within the account settings, a "source" property will be captured with the above. Values = "signup_epilogue" and "account_settings"

To test:
Prereqs

  • Launch the app
  • Navigate to Me -> App Settings -> Privacy Settings
  • Turn on Collect Information
  • Logout

Test tracking events are in the logs

  • Start the create the signup flow by entering a new email
  • View your email
  • Launch the app by tapping the "Sign up to WordPress.com" in the signup email
  • You should now be in the Signup Epilogue view
  • Tap the username to launch the Change Username full screen dialog
  • ✅ Verify the logs contain: 🔵 Tracked: change_username_displayed, Properties: {"source":"signup_epilogue"}
  • Enter some text in the search view
  • ✅ Verify the logs contain: 🔵 Tracked: change_username_search_performed, Properties: {"source":"signup_epilogue"}
  • Tap the X button
  • ✅ Verify the logs contain: 🔵 Tracked: change_username_dismissed, Properties: {"source":"signup_epilogue"}
  • Finish creating the account
  • Tap on Me -> Account Settings to launch the Change Username full screen dialog
  • ✅ Verify the logs contain: 🔵 Tracked: change_username_displayed, Properties: {"source":"account_settings"}
  • Enter some text in the search view
  • ✅ Verify the logs contain: 🔵 Tracked: change_username_search_performed, Properties: {"source":"account_settings"}
  • Tap the X button
  • ✅ Verify the logs contain: 🔵 Tracked: change_username_dismissed, Properties: {"source":"account_settings

Regression Notes

  1. Potential unintended areas of impact
    The events are not tracked

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    Manual testing

  3. What automated tests I added (or what prevented me from doing so)
    N/A

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@zwarm zwarm added this to the 19.8 milestone Apr 21, 2022
@zwarm
zwarm requested a review from ashiagr April 21, 2022 18:20
@zwarm zwarm self-assigned this Apr 21, 2022
@peril-wordpress-mobile

Copy link
Copy Markdown

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

@zwarm zwarm mentioned this pull request Apr 21, 2022
18 tasks done
@peril-wordpress-mobile

Copy link
Copy Markdown

You can test the changes on this Pull Request by downloading the APKs:

@ashiagr

ashiagr commented Apr 22, 2022

Copy link
Copy Markdown
Contributor

Tested change username flow. All events are tracked as described. Also, code changes look good to me.
Good job, @zwarm!

@ashiagr
ashiagr merged commit 9196dfe into trunk Apr 22, 2022
@ashiagr
ashiagr deleted the issue/16343-change-username-flow-tracking branch April 22, 2022 05:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants