Skip to content

Integrate gutenberg-mobile release 1.54.0 - #14739

Merged
jhnstn merged 5 commits into
developfrom
gutenberg/integrate_release_1.54.0
May 29, 2021
Merged

jhnstn merged 5 commits into
developfrom
gutenberg/integrate_release_1.54.0

Conversation

@jhnstn

@jhnstn jhnstn commented May 28, 2021 •

Copy link
Copy Markdown
Member

Description

This PR incorporates the 1.54.0 release of gutenberg-mobile.
For more information about this release and testing instructions, please see the related Gutenberg-Mobile PR: wordpress-mobile/gutenberg-mobile#3559

Release Submission Checklist

  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@peril-wordpress-mobile

peril-wordpress-mobile Bot commented May 28, 2021 •

Copy link
Copy Markdown

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

@peril-wordpress-mobile

peril-wordpress-mobile Bot commented May 28, 2021 •

Copy link
Copy Markdown

You can test the changes on this Pull Request by downloading the APK here.

@jhnstn
jhnstn marked this pull request as ready for review May 28, 2021 02:29
@jhnstn
jhnstn requested a review from mkevins May 28, 2021 02:30

@dcalhoun dcalhoun left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking good so far. Before merging we'll need to...

  1. Update the release notes.
  2. Update the gutenbergMobileVersion ref to be the release tag once we create it.

Then we should be able to merge.

@dcalhoun dcalhoun added this to the 17.5 milestone May 28, 2021
@enejb

enejb commented May 28, 2021 •

Copy link
Copy Markdown
Contributor

DarkMode - 1

Group - 1

  • Group - AppenderButton is rendered - TC001
  • Group - Deep nesting is possible (iOS only) - TC002
  • Group - Check if Group placeholder is visible for the unselected state - TC003
  • Group - Check if Group placeholder is render in nested structure - TC004
  • Group - Nested block have proper border styling - TC005
  • Group - Nested block have proper margins values - TC006
  • Group - Breadcrumbs on FloatingToolbar is properly displayed - TC008

Spacer - 1

  • Spacer block - Spacer is rendered without crash - TC001
  • Spacer block - Settings: Control spacer height using the slider - TC002
  • Spacer block - Settings: Control spacer height using the text input - TC003

Buttons-1

  • Buttons block - Buttons block is added with focused Button with gray background color and white text color - TC001
  • Buttons block - Buttons inline appender - TC002
  • Buttons block - Add another Button inside Buttons using inserter - TC003
  • Buttons block - Button's wrapper grows properly - TC023

Buttons-2

  • Buttons block - Removing Button along with Buttons block - TC004
  • Buttons block - Removing exactly one Button (when Buttons contain more of them) - TC005

Buttons-3

  • Buttons block - Wrapping Buttons - TC006
  • Buttons block - Buttons alignment options - TC007

Button-6

  • Buttons block - Settings: Open in new tab - TC011
  • Buttons block - Settings: Link rel - TC012
  • Buttons block - Settings: Link URL - TC010
  • Buttons block - Settings: Remove link - TC014
  • Buttons block - Settings: Synchronize with button options - TC013

Color Settings - 1

  • Colors Segmented Controls - TC001
  • Scroll color palette to start - TC002
  • Scroll color palette to the end - TC003

Image - 1

  • Image block - Insert image from device (failing) - TC001
  • Image block - Insert image from device (cancel) - TC002
  • Image block - Add Caption - TC003
  • Image block - Close/Re-open post with an ongoing image upload - TC004
  • Image block - Close post with an ongoing image upload - TC005

@enejb

enejb commented May 28, 2021

Copy link
Copy Markdown
Contributor

I ran into this error when I switched from the dark mode to light mode and had the editor open.
wp-1622237510587

Although I am having a hard time replication this issue.

@enejb

enejb commented May 28, 2021 •

Copy link
Copy Markdown
Contributor

Story block - 1

  • Story block - Verify is available in Block Picker - TC001
  • Story block - Verify is not available in Block Picker- TC002
  • Story block - Add media to empty Story block - TC003
  • Story block - Add media to non-empty Story block - TC004
  • Story block - Close/Re-open post with an ongoing Story upload - TC005

@jhnstn
jhnstn merged commit 01e7407 into develop May 29, 2021
@jhnstn
jhnstn deleted the gutenberg/integrate_release_1.54.0 branch May 29, 2021 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants