You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Preserve scroll and caret position after rotating (Gutenberg Editor) #8739
Assuming this is related, @rachelmcr reported some more issues on rotation:
when I rotated between portrait and landscape the content prompt and toolbar disappeared and took a noticeable amount of time to reappear on screen
If I rotate the device with a post that has content, all the content disappears and takes some time to reload
I imagine this is caused by the same thing (Android reloading the full RN view when rotating), but feel free to create separate issues if not
Unassigning, sorry for keeping myself assigned to it @hypest
What happened is: this is something I assigned to me because I thought of fixing it with #8874 with the GutenbergEditPostActivity (that PR was created 2 days later), but this other approach has been superseeded now as per this. In this other approach, as you mentioned in our video call, still needs the caret position and scroll position to be preserved, so this issue is still valid and needs to be tackled.
Assuming this is related, @rachelmcr reported some more issues on rotation:
when I rotated between portrait and landscape the content prompt and toolbar disappeared and took a noticeable amount of time to reappear on screen
If I rotate the device with a post that has content, all the content disappears and takes some time to reload
I imagine this is caused by the same thing (Android reloading the full RN view when rotating), but feel free to create separate issues if not
Performance and caret position are addressed in #9030 . Scrolling position will most probably be handled in a separate PR.
Activity
koke commentedon Dec 10, 2018
Can you add this as part of wordpress-mobile/gutenberg-mobile#196 instead to keep track of it for the alpha?
marecar3 commentedon Dec 10, 2018
@koke done.
koke commentedon Dec 13, 2018
Assuming this is related, @rachelmcr reported some more issues on rotation:
I imagine this is caused by the same thing (Android reloading the full RN view when rotating), but feel free to create separate issues if not
mzorz commentedon Dec 18, 2018
Moving to
Betaand unassigning it for now a per the following #8800 (comment)mzorz commentedon Jan 31, 2019
Unassigning, sorry for keeping myself assigned to it @hypest
What happened is: this is something I assigned to me because I thought of fixing it with #8874 with the
GutenbergEditPostActivity(that PR was created 2 days later), but this other approach has been superseeded now as per this. In this other approach, as you mentioned in our video call, still needs the caret position and scroll position to be preserved, so this issue is still valid and needs to be tackled.Unassigning as per conversation then 👍
hypest commentedon Feb 5, 2019
Performance and caret position are addressed in #9030 . Scrolling position will most probably be handled in a separate PR.