Skip to content

Preserve scroll and caret position after rotating (Gutenberg Editor) #8739

Closed

Description

@marecar3

Preserve scroll and caret position after rotating in Gutenberg Editor

Activity

  1. koke commented on Dec 10, 2018

    @koke
    Member

    Can you add this as part of wordpress-mobile/gutenberg-mobile#196 instead to keep track of it for the alpha?

  2. marecar3 commented on Dec 10, 2018

    @marecar3
    ContributorAuthor

    @koke done.

  3. koke commented on Dec 13, 2018

    @koke
    Member

    Assuming this is related, @rachelmcr reported some more issues on rotation:

    when I rotated between portrait and landscape the content prompt and toolbar disappeared and took a noticeable amount of time to reappear on screen
    If I rotate the device with a post that has content, all the content disappears and takes some time to reload

    I imagine this is caused by the same thing (Android reloading the full RN view when rotating), but feel free to create separate issues if not

  4. self-assigned this
    on Dec 13, 2018
  5. removed their assignment
    on Dec 18, 2018
  6. mzorz commented on Dec 18, 2018

    @mzorz
    Contributor

    Moving to Beta and unassigning it for now a per the following #8800 (comment)

  7. self-assigned this
    on Dec 24, 2018
  8. mzorz commented on Jan 31, 2019

    @mzorz
    Contributor

    Unassigning, sorry for keeping myself assigned to it @hypest

    What happened is: this is something I assigned to me because I thought of fixing it with #8874 with the GutenbergEditPostActivity (that PR was created 2 days later), but this other approach has been superseeded now as per this. In this other approach, as you mentioned in our video call, still needs the caret position and scroll position to be preserved, so this issue is still valid and needs to be tackled.

    Unassigning as per conversation then 👍

  9. removed their assignment
    on Jan 31, 2019
  10. hypest commented on Feb 5, 2019

    @hypest
    Contributor

    Assuming this is related, @rachelmcr reported some more issues on rotation:

    when I rotated between portrait and landscape the content prompt and toolbar disappeared and took a noticeable amount of time to reappear on screen
    If I rotate the device with a post that has content, all the content disappears and takes some time to reload

    I imagine this is caused by the same thing (Android reloading the full RN view when rotating), but feel free to create separate issues if not

    Performance and caret position are addressed in #9030 . Scrolling position will most probably be handled in a separate PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    GutenbergEditing and display of Gutenberg blocks.[Type] Task

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions