Remove MAX_LEDS_PER_BUS limitation for virtual buses#5238
Merged
Conversation
Contributor
|
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the Comment |
- Frontend: Updated settings_leds.htm to allow virtual buses up to 16384 LEDs - Backend: Modified BusConfig::adjustBounds() to skip MAX_LEDS_PER_BUS check for virtual buses - Tests: All npm tests pass successfully Co-authored-by: DedeHai <6280424+DedeHai@users.noreply.github.com>
Co-authored-by: DedeHai <6280424+DedeHai@users.noreply.github.com>
Co-authored-by: DedeHai <6280424+DedeHai@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Remove restriction on virtual bus size exceeding MAX_LEDS_PER_BUS
Remove MAX_LEDS_PER_BUS limitation for virtual buses
Dec 28, 2025
DedeHai
approved these changes
Dec 28, 2025
softhack007
reviewed
Dec 28, 2025
.gitignore
Outdated
| /wled00/Release | ||
| /wled00/wled00.ino.cpp | ||
| /wled00/html_*.h | ||
| _codeql_detected_source_root |
Member
There was a problem hiding this comment.
What does this do? Is it related to the rest of the PR?
Collaborator
|
@copilot please revert unnecessary change to .gitignore |
Co-authored-by: DedeHai <6280424+DedeHai@users.noreply.github.com>
Contributor
Author
DedeHai
approved these changes
Dec 29, 2025
willmmiles
approved these changes
Dec 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Plan to Remove MAX_LEDS_PER_BUS Limitation for Virtual Buses
Based on the issue description and reference commit, virtual buses (like DDP, ArtNet, E131) are incorrectly limited to MAX_LEDS_PER_BUS (2048 on ESP32) when they should support up to MAX_LEDS (16384 on ESP32).
Changes Required:
Frontend (wled00/data/settings_leds.htm):
d.Sf["LC"+n].max = maxPBfor all bus typesif (nm=="LC")section to set max value based on bus type:maxLCcalculation to only apply for digital busesBackend (wled00/bus_manager.h):
BusConfig::adjustBounds()to only apply MAX_LEDS_PER_BUS limit to non-virtual busesTesting:
Address feedback:
Summary:
All changes are complete and validated. Virtual buses can now be configured with up to 16384 LEDs instead of being limited to 2048 LEDs. The implementation follows the reference commit and maintains backward compatibility for physical buses while removing the artificial limitation for virtual/network buses.
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.