Skip to content

fix: handle deleted one-on-one details [WPB-8645]#4229

Open
MohamadJaara wants to merge 2 commits into
developfrom
mo/global-search
Open

fix: handle deleted one-on-one details [WPB-8645]#4229
MohamadJaara wants to merge 2 commits into
developfrom
mo/global-search

Conversation

@MohamadJaara

@MohamadJaara MohamadJaara commented Jun 18, 2026

Copy link
Copy Markdown
Member

https://wearezeta.atlassian.net/browse/WPB-8645

Summary

  • tolerate one-on-one conversation rows where the other user id is missing
  • mark that fallback user as deleted so clients can render the deleted account state instead of crashing
  • add a mapper regression test for deleted 1:1 details

Tests

  • ./gradlew :kalium:logic:jvmTest --tests com.wire.kalium.logic.data.conversation.ConversationMapperTest

@github-actions

github-actions Bot commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

Test Results

0 tests   - 5 871   0 ✅  - 5 730   0s ⏱️ - 4m 25s
0 suites  -   889   0 💤  -   141 
0 files    -   889   0 ❌ ±    0 

Results for commit 6634c01. ± Comparison against base commit d57f18f.

♻️ This comment has been updated with latest results.

@MohamadJaara MohamadJaara marked this pull request as ready for review July 14, 2026 09:42
@MohamadJaara MohamadJaara changed the title Handle deleted one-on-one details fix: handle deleted one-on-one details Jul 14, 2026
@sonarqubecloud

Copy link
Copy Markdown

@MohamadJaara MohamadJaara changed the title fix: handle deleted one-on-one details fix: handle deleted one-on-one details [WPB-8645] Jul 14, 2026
@MohamadJaara MohamadJaara enabled auto-merge July 14, 2026 09:49
@github-actions

Copy link
Copy Markdown
Contributor

🐰 Bencher Report

Branch${GITHUB_HEAD_REF}
Testbedubuntu-latest

⚠️ WARNING: No Threshold found!

Without a Threshold, no Alerts will ever be generated.

Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the --ci-only-thresholds flag.

Click to view all benchmark results
BenchmarkLatencymicroseconds (µs)
com.wire.kalium.benchmarks.logic.CoreLogicBenchmark.createObjectInFiles📈 view plot
⚠️ NO THRESHOLD
884.36 µs
com.wire.kalium.benchmarks.logic.CoreLogicBenchmark.createObjectInMemory📈 view plot
⚠️ NO THRESHOLD
336,087.96 µs
com.wire.kalium.benchmarks.persistence.MessageReadBenchmark.inboxPagingDeepPageBenchmark📈 view plot
⚠️ NO THRESHOLD
133,668.59 µs
com.wire.kalium.benchmarks.persistence.MessageReadBenchmark.inboxPagingFirstPageBenchmark📈 view plot
⚠️ NO THRESHOLD
130,848.87 µs
com.wire.kalium.benchmarks.persistence.MessageReadBenchmark.localMarkAsReadBenchmark📈 view plot
⚠️ NO THRESHOLD
3,986.49 µs
com.wire.kalium.benchmarks.persistence.MessageReadBenchmark.messagePagingDeepPageBenchmark📈 view plot
⚠️ NO THRESHOLD
37,478.99 µs
com.wire.kalium.benchmarks.persistence.MessageReadBenchmark.messagePagingFirstPageBenchmark📈 view plot
⚠️ NO THRESHOLD
21,923.41 µs
com.wire.kalium.benchmarks.persistence.MessagesNoPragmaTuneBenchmark.messageInsertionBenchmark📈 view plot
⚠️ NO THRESHOLD
1,247,073.53 µs
com.wire.kalium.benchmarks.persistence.MessagesNoPragmaTuneBenchmark.queryMessagesBenchmark📈 view plot
⚠️ NO THRESHOLD
20,246.40 µs
🐰 View full continuous benchmarking report in Bencher

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants