Fix: Improve Claude binary detection for NVM and production builds by joebwd · Pull Request #4 · winfunc/opcode

joebwd · 2025-06-20T05:06:46Z

Summary

Fixes Claude binary detection when installed via NVM (Node Version Manager)
Enables the 'which' command in production builds (was previously disabled)
Resolves issue Failed to execute Claude Code #2: "Failed to execute Claude Code"

Changes

Enable 'which' command in production builds: Removed the conditional compilation that disabled 'which' in production, allowing better PATH resolution
Add NVM support: Added logic to scan ~/.nvm/versions/node/*/bin/ directories to find Claude installations managed by NVM
Improved search order: The binary search now follows this priority:
- User settings (if configured)
- PATH resolution via 'which' command
- NVM installations (newest versions first)
- Common system locations (/usr/local/bin, /opt/homebrew/bin)
- User-specific locations (~/.claude/local, ~/.local/bin)
Better error messages: Updated error message to include NVM path hint

Test plan

Test with Claude installed via NVM
Test with Claude in standard system paths
Test in production build (no longer blocked by conditional compilation)
Verify error message includes all search paths

Related Issues

Fixes #2

- Enable 'which' command in production builds (was previously disabled) - Add NVM node versions directory scanning to find Claude installations - Sort NVM versions to check newest first - Remove unnecessary /usr/bin and /bin paths from search - Update error message to include NVM path hint - Fixes issue winfunc#2: Claude binary not found when installed via NVM

- Add NVM path detection to find_claude_binary in mcp.rs - Handle NVM-installed Claude by using node directly to run the script - Ensure Node.js bin directory is added to PATH for NVM installations - Update error messages to include NVM paths This fixes "Failed to load MCP servers" error when Claude is installed via NVM

tebayoso · 2025-06-20T06:05:32Z

I actually opened a very similar PR, and when started to use it locally, problems showed up:
-If you have multiple node versions with different claude code versions the selector will pick the first one (which is usually outdated)
-If you have nvm and system binaries installed, there's no way to select the correct one.
-MCP Servers has the same problem and that file has a separated strategy. I'm updating my PR with a whole new approach.

joebwd · 2025-06-20T13:41:27Z

Awesome - thank you!

Introduces a dedicated module for detecting Claude Code binary installations with support for multiple sources including NVM, aliased paths, and version-based selection. This shared module improves the reliability of finding Claude installations across different environments. Key features: - Supports multiple installation sources (NVM, system, homebrew, npm, yarn, bun) - Handles aliased paths from 'which' command - Version-aware selection to prefer latest installations - Database caching of discovered binary paths - Comprehensive logging for debugging - Environment variable preservation for NVM compatibility The implementation is inspired by: - #3 - #4

mufeedvh · 2025-06-23T18:57:42Z

Implemented a solution that takes inspiration from this PR and #3. Thank you so much! ❤️

ceramicwhite · 2025-06-24T05:26:34Z

Building on MacOS still getting:

warning: unused variable: `claude_path`
   --> src/commands/claude.rs:442:9
    |
442 |     let claude_path = find_claude_binary(&app)?;
    |         ^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_claude_path`
    |
    = note: `#[warn(unused_variables)]` on by default`

running dev though does find the binary from nvm via /opt/homebrew/bin/claude

I preferred #3 with the dropdown for selecting the version I wanted to use which worked great

…binary detection This commit provides a comprehensive solution to Claude binary detection issues by implementing a user-friendly version selector UI and improving the binary discovery logic. It addresses all concerns raised in multiple PRs and comments. Changes: - Add ClaudeVersionSelector component for selecting from multiple installations - Update ClaudeBinaryDialog to use version selector instead of manual path input - Fix unused variable warning in production builds (claude.rs:442) - Improve select_best_installation to handle production build restrictions - Add listClaudeInstallations API endpoint to fetch all available installations - Make Claude version indicator clickable to navigate to Settings - Move Claude installation selector to General tab in Settings (per user request) - Enhance dialog UX with loading states and clear installation instructions - Add Radix UI radio-group dependency for version selector Fixes: - Production build warning about unused claude_path variable - Version detection failures in production builds due to process restrictions - Poor UX when Claude binary is not found (now shows helpful dialog) - Inability to easily switch between multiple Claude installations This implementation takes inspiration from: - PR #3: Version selector dropdown approach (preferred by users) - PR #4: Binary detection improvements and path validation - PR #39: Additional detection methods and error handling - Commit 5a29f9a: Shared claude binary detection module architecture Addresses feedback from: - #4 (comment): User preference for dropdown selector - Production build restrictions that prevent version detection - Need for better error handling when Claude is not installed The solution provides a seamless experience whether Claude is installed via: - npm/yarn/bun global installation - nvm-managed Node.js versions - Homebrew on macOS - System-wide installation - Local user installation (~/.local/bin, etc.) Refs: #3, #4, #39, 5a29f9a

Introduces a dedicated module for detecting Claude Code binary installations with support for multiple sources including NVM, aliased paths, and version-based selection. This shared module improves the reliability of finding Claude installations across different environments. Key features: - Supports multiple installation sources (NVM, system, homebrew, npm, yarn, bun) - Handles aliased paths from 'which' command - Version-aware selection to prefer latest installations - Database caching of discovered binary paths - Comprehensive logging for debugging - Environment variable preservation for NVM compatibility The implementation is inspired by: - winfunc/opcode#3 - winfunc/opcode#4

…binary detection This commit provides a comprehensive solution to Claude binary detection issues by implementing a user-friendly version selector UI and improving the binary discovery logic. It addresses all concerns raised in multiple PRs and comments. Changes: - Add ClaudeVersionSelector component for selecting from multiple installations - Update ClaudeBinaryDialog to use version selector instead of manual path input - Fix unused variable warning in production builds (claude.rs:442) - Improve select_best_installation to handle production build restrictions - Add listClaudeInstallations API endpoint to fetch all available installations - Make Claude version indicator clickable to navigate to Settings - Move Claude installation selector to General tab in Settings (per user request) - Enhance dialog UX with loading states and clear installation instructions - Add Radix UI radio-group dependency for version selector Fixes: - Production build warning about unused claude_path variable - Version detection failures in production builds due to process restrictions - Poor UX when Claude binary is not found (now shows helpful dialog) - Inability to easily switch between multiple Claude installations This implementation takes inspiration from: - PR #3: Version selector dropdown approach (preferred by users) - PR #4: Binary detection improvements and path validation - PR #39: Additional detection methods and error handling - Commit 5a29f9a: Shared claude binary detection module architecture Addresses feedback from: - winfunc/opcode#4 (comment): User preference for dropdown selector - Production build restrictions that prevent version detection - Need for better error handling when Claude is not installed The solution provides a seamless experience whether Claude is installed via: - npm/yarn/bun global installation - nvm-managed Node.js versions - Homebrew on macOS - System-wide installation - Local user installation (~/.local/bin, etc.) Refs: #3, #4, #39, 5a29f9a

joebwd added 2 commits June 19, 2025 22:05

mufeedvh mentioned this pull request Jun 23, 2025

feat: Enhanced Claude Code Detection with NVM Integration & Multi-Version Management #3

Closed

7 tasks

mufeedvh closed this Jun 23, 2025

Kirchlive mentioned this pull request Jul 4, 2025

Windows Support for Claudia - Community Fix Available 4.2 FINAL #78

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix: Improve Claude binary detection for NVM and production builds#4

Fix: Improve Claude binary detection for NVM and production builds#4
joebwd wants to merge 2 commits intowinfunc:mainfrom
joebwd:fix/claude-binary-nvm-detection

joebwd commented Jun 20, 2025

Uh oh!

tebayoso commented Jun 20, 2025

Uh oh!

joebwd commented Jun 20, 2025

Uh oh!

mufeedvh commented Jun 23, 2025

Uh oh!

ceramicwhite commented Jun 24, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

joebwd commented Jun 20, 2025

Summary

Changes

Test plan

Related Issues

Uh oh!

tebayoso commented Jun 20, 2025

Uh oh!

joebwd commented Jun 20, 2025

Uh oh!

mufeedvh commented Jun 23, 2025

Uh oh!

ceramicwhite commented Jun 24, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants