Repository navigation
Build documentation - #204
Merged
Merged
Conversation
This would otherwise fail when building on Windows/Cygwin
Collaborator
|
Thanks for the PR. I merged this in. Regarding the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have just tried to build sshfs-win on my Windows machine (using Cygwin, since I assumed it is the expected way to do so).
I added little documentation that I wished I had before I built it.
I also added a
--binaryflag topatchin the Makefile. It turned out it worked this way on my machine, but maybe this depends on how anyone configures his line endings. Please review this commit and tell me what you think about it. Otherwise, I could add something like "try without this flag first, then with this flag if the former fails"