Repository navigation
Conversation
The FileInfo that WinFsp passes to Create and Open points into an FSP_FSCTL_OPEN_FILE_INFO, whose NormalizedName buffer lets a file system report the name as it is stored when it was opened under another case. go-winfsp declares the struct but gives no way to reach or fill it, so a case-insensitive file system can't: WinFsp then keeps the name as it was opened, and reports that through GetFinalPathNameByHandle and FileNameInformation. Add GetOpenFileInfo, the Go version of FspFileSystemGetOpenFileInfo, and FSP_FSCTL_OPEN_FILE_INFO.SetNormalizedName, which copies a name into WinFsp's buffer if it fits. A file system that doesn't call them is unaffected: WinFsp ignores an unset NormalizedName.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The FileInfo that WinFsp passes to Create and Open points into an FSP_FSCTL_OPEN_FILE_INFO, whose NormalizedName buffer lets a file system report the name as it is stored when it was opened under another case. go-winfsp declares the struct but gives no way to reach or fill it, so a case-insensitive file system can't: WinFsp then keeps the name as it was opened, and reports that through GetFinalPathNameByHandle and FileNameInformation.
Add GetOpenFileInfo, the Go version of FspFileSystemGetOpenFileInfo, and FSP_FSCTL_OPEN_FILE_INFO.SetNormalizedName, which copies a name into WinFsp's buffer if it fits. A file system that doesn't call them is unaffected: WinFsp ignores an unset NormalizedName.