Repository navigation
Add cgo hints to reduce overhead of certain cgo calls - #106
Open
jfantinhardesty wants to merge 4 commits into
Open
jfantinhardesty wants to merge 4 commits into
jfantinhardesty wants to merge 4 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This uses cgo features introduced in go 1.24 which allows go to optimize some of the cgo calls by noting that those functions do not call back to go code and if the go pointers do not escape the C function. Is some testing with our FUSE filesystem, we find that this improves performance from 2%-10% (though most improvements are closer to 2%). Some read directory heavy workloads see a larger improvement with these changes.
This does require bumping the go version to 1.24, but this should be fine as 1.24 is EOL anyways.