fix(serializer): omit absent optional fields instead of null - #128
Open
Steve0x2a wants to merge 1 commit into
Open
fix(serializer): omit absent optional fields instead of null#128Steve0x2a wants to merge 1 commit into
Steve0x2a wants to merge 1 commit into
Conversation
Signed-off-by: Yi Zhan <stevesough@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When an ABI optional field is absent, decode now omits the key instead of assigning
null.Serializer.objectifyalso drops null keys so JSON-like output matches the Struct path.eosio.msig::approvewithoutproposal_hashpreviously round-tripped to{…, proposal_hash: null}, whichwharfkit/wallet-plugin-cleosthen passed to cleos and cleos rejected. Present optionals are unchanged. Top-level optional types such aspublic_key?still decode tonull. Missing binary extensions still decode tonull.Credit @aaroncox for the report and repro.
Fixes #113