feat(tempo): add resolveAccount hooks#576
Closed
parvahuja wants to merge 2 commits into
Closed
Conversation
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #571. This branch is stacked on the channel store work so the session hook can see cached channel state.
What
resolveAccounthook shared by charge and session clients.Why
Wallet and account SDKs need to decide which account signs each Tempo action, especially for access-key backed charge and session flows, without mppx depending on a specific account SDK.
Validation
VITE_TEMPO_NETWORK=none pnpm exec vp test --run src/tempo/client/Charge.test.ts src/tempo/session/client/Session.test.ts src/tempo/session/precompile/Voucher.test.tsVITE_TEMPO_NETWORK=none pnpm exec vp test --run src/tempo/session/ src/tempo/client/Charge.test.tspnpm check:typespnpm check:cipnpm audit --ignore-registry-errors