Repository navigation
Conversation
|
@omerbek is attempting to deploy a commit to the Wevm Team on Vercel. A member of the Team first needs to authorize it. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Problem
On Windows,
git rev-parse --show-toplevelcan return a root such asC:/repo, whileStore.filenormalizes the same path toC:\\repo.logandsynccompare those strings and reject the equivalent paths withSTORE_ROOT_MISMATCH.Root cause
context.resolveforwarded Git's root verbatim, while the file store independently passed its root throughpath.resolve.Change
Normalize the repository root once in
context.resolvewithpath.resolve. This gives config, remotes, the default file store, and injected-store validation one canonical platform path.Fixes #82.
Testing
corepack pnpm test src/cli/internal/context.test.ts— 1 passedcorepack pnpm check:types— passedcorepack pnpm check— formatting, lint, and type checks passed for 115 filesfrog log ... --cwd <temp>created one pending entry and exited 0Risk
Low. The change only canonicalizes the root path before existing consumers use it. Different real directories still fail the injected-store root check; equivalent Windows separator forms no longer do.
Additional verification note
corepack pnpm buildreacheszilebut fails on this Windows environment whenzilespawnsnode_modules/.bin/tscwithout the Windows command shim (ENOENT). The repository's directpnpm check:typescommand passes.