Skip to content

fix: eliminate GNU awk lint shadowing warnings - #22

Merged
wesley-dean merged 1 commit into
mainfrom
fix/gawk-line-shadowing
Sep 14, 2026
Merged

wesley-dean merged 1 commit into
mainfrom
fix/gawk-line-shadowing

Conversation

@wesley-dean

@wesley-dean wesley-dean commented Sep 14, 2026 •

Copy link
Copy Markdown
Owner

Removes the GNU awk --lint shadowing warnings reported from current main without changing filter behavior.

The JavaScript filter's rule-level scratch variable is renamed from global line to filtered_line, leaving the documented function parameter names unchanged. The retained Python filter had the same global-shadowing pattern, so its rule-level scratch variable is likewise renamed to source_line.

The Makefile now exposes make check, which runs GNU awk lint across the maintained root *.awk filter sources. make test remains unchanged as the lightweight TAP-only surface governed by ADR-018. CI invokes make check explicitly in the GNU awk semantic job so future lint regressions are caught without changing the make test contract.

This PR is intentionally separate from PR #21 because the warnings exist on main and are unrelated to release publication.

@github-actions

github-actions Bot commented Sep 14, 2026 •

Copy link
Copy Markdown
Contributor

✅MegaLinter analysis: Success

Descriptor Linter Files Fixed Errors Max errors Warnings Elapsed time
✅ REPOSITORY betterleaks yes no no 1.14s
✅ REPOSITORY checkov yes no no 22.02s
✅ REPOSITORY grype yes no no 72.18s
✅ REPOSITORY kingfisher yes no no 5.49s
✅ REPOSITORY secretlint yes no no 1.62s
✅ REPOSITORY semgrep yes no no 24.58s
✅ REPOSITORY syft yes no no 3.35s
✅ REPOSITORY trivy yes no no 10.94s
✅ REPOSITORY trivy-sbom yes no no 0.18s
✅ REPOSITORY trufflehog yes no no 4.07s

See detailed reports in MegaLinter artifacts
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is provided by OX Security
Show us your support by starring ⭐ the repository

@wesley-dean
wesley-dean force-pushed the fix/gawk-line-shadowing branch from f0af422 to f87cba2 Compare September 14, 2026 20:44
@wesley-dean
wesley-dean merged commit 51b153f into main Sep 14, 2026
20 checks passed
@wesley-dean
wesley-dean deleted the fix/gawk-line-shadowing branch September 14, 2026 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant