Repository navigation
docs(readme): describe the stack that actually ships - #6
Merged
Merged
Conversation
The Stack section documented #080808/#00FFD1/Geist/strict dark mode, none of which survived the palette and theming work. Stop restating values that live in code: link app/globals.css instead of copying hexes, so the section cannot rot the same way again.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
The earlier wording documented the hardcoded star count as current. PR #7 removes it, so the line would have shipped false. Describes the behaviour both PRs agree on instead, which makes merge order irrelevant.
Contributor
Author
|
Updated for the interaction with #7. The Live data bullet previously read "The hero still falls back to a hardcoded star count when a lookup fails (#3)". #7 removes that fallback, so the line would have merged already-false. It now describes the behaviour both branches agree on:
No file overlap between the two branches, so CI would not have caught this. Merge order no longer matters. |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2
What
README.mddocumented a design system the site no longer has. The Stack sectionnow describes what ships, and stops restating values that live in code.
Why it was wrong
#080808background#12141Fdark /#FAF8F3light#00FFD1accent#F5B841dark /#9C6100lightThe Geist line was wrong before any of this:
app/layout.tsxloadedIBM_Plex_Monounder a variable merely named--font-geist, so the READMElooked consistent with the code while both were wrong.
The fix is deletion, not restatement
The section rotted because it duplicated values owned by
app/globals.css.Rewriting the hexes would just reset the clock. Instead the palette bullet links
the file and describes the system in words that stay true when a token changes.
That is also why this PR carries no test: after the change there is no duplicated
constant left for a test to compare.
Verified
Every remaining claim grepped against source on this branch:
One thing caught in review of my own draft
My first pass wrote "nothing on the page is a number typed by hand" under Live
data. That is false — the hero falls back to a hardcoded
'300+', which is#3. Rewriting a doc to be true and slipping a fresh untrue sentence in is the
exact failure this PR exists to fix. The bullet now states the fallback and links
the issue.
Out of scope
README.md:9carries a "not just X, it's Y" construction. Real, but not part of#2, so it stays. Worth a separate ticket if the prose gets a pass.