Repository navigation
fix(site): stop clipping the mark, which is a squircle already - #34
Merged
Merged
Conversation
The brand mark got a border-radius when the radius ladder went in, on the assumption that it was a plain square image. weekndlabs.com now serves a squircle with its own silhouette, so a CSS corner on top cuts into the curve the mark already has and the two fight at every size. The chrome loads the mark from weekndlabs.com, so this follows that repo rather than leading it.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
weekndlabs.com now serves a mark whose silhouette is a real superellipse, drawn
in the system's neutral ground and system blue. The docs chrome loads that file
by absolute URL, so it picks the new one up on its own.
What it should not do is round it again. The
border-radiushere dates from theradius ladder landing, when the mark was a plain square, and a CSS corner on top
of a squircle cuts into the curve it already has.