Repository navigation
fix(docs): link between the two pages absolutely, like everything else - #21
Merged
Merged
Conversation
The guide link shipped in #20 was relative and broke on the proxied host. Next serves that page as weekndlabs.com/design with no trailing slash, so the browser resolved `./guide/` against `/` and landed on weekndlabs.com/guide, outside the docs. The page did not render. On the subdomain the same href worked, which is why the local check passed. SiteChrome.astro already states the rule and the reason: every link is absolute because the page answers on two hosts and a relative href points somewhere different depending on which one served it. These two links now follow it. Checked against the live site rather than a local build, since a local server cannot reproduce a path prefix that only the proxy adds.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
fajarhide
added a commit
that referenced
this pull request
Jul 27, 2026
…on (#22) The two page links now target weekndlabs.com/design rather than the subdomain, so a visitor stays on the main site. Still absolute, for the reason #21 established: the page answers on two hosts and a relative href resolves differently on each. No trailing slash on the path. weekndlabs.com/design/guide/ answers 308 to the version without it, so linking with one spends a redirect on every visitor. The docs site had no favicon at all, so browsers drew their own. It now points at weekndlabs.com's three icons rather than copying them in, the same way SiteChrome.astro already loads the brand mark from there. icon.png has been changed once before, and two copies drifting apart is the thing worth avoiding. All four referenced URLs check out 200 with the right content type. Note that the canonical still names design.weekndlabs.com while these links name weekndlabs.com/design. That is deliberate to leave alone for now, but the two disagree and it is worth settling.
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The guide link shipped in #20 was relative, and it broke on the host it was written to support.
Next serves the proxied page as
weekndlabs.com/designwith no trailing slash, so the browser resolves./guide/against/and lands onweekndlabs.com/guide. Outside the docs, nothing rendered.weekndlabs.com/design./guide/weekndlabs.com/guidedesign.weekndlabs.com/./guide/design.weekndlabs.com/guide/SiteChrome.astroalready carries the rule and the reason:I wrote a comment in #20 arguing the opposite and shipped exactly the failure that comment predicts. Both links are now absolute to the canonical host, which is where the canonical URL already points.
Why the local check missed it
I tested both links against a local
serveand they passed, because a local server has no/designprefix. Only the proxy adds it, so only the live site can show the bug. This was caught by driving the deployed site after merging, which is the check that should have run before.