Running locally (Ding Dong bot) by shwetalsoni · Pull Request #888 · wechaty/docusaurus

shwetalsoni · 2021-05-23T17:23:18Z

…to running-locally

shwetalsoni · 2021-05-24T17:36:04Z

Tag: #891

…to running-locally

Rohitesh-Kumar-Jain · 2021-05-25T14:01:28Z

Is the PR ready to be reviewd? You requested Review, but I believe you are still pushing new commits to the PR

shwetalsoni · 2021-05-25T14:05:36Z

Now its done. You can review it now.

…

On Tue, 25 May 2021, 7:31 pm Rohitesh Kumar Jain, ***@***.***> wrote: Is the PR ready to be reviewd? You requested Review, but I believe you are still pushing new commits to the PR — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <https://github.com/wechaty/wechaty.js.org/pull/888#issuecomment-847896408>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ANUJ3INXA6AXGKQZ35NKI3LTPOUUZANCNFSM45L44ORQ> .

lijiarui

After I running this locally, here is the suggestion:

1. change the file name

If our title is Running locally,how about we change the title to getting-started/running-locally.mdx

2. Fix CodeSandbox error

I run this locally and found error here, I think you should fix this error fist.

lijiarui

Please change as I request.

lijiarui · 2021-07-06T17:16:05Z

+  "dotenv": "^8.2.0",
+  "qrcode-terminal": "^0.12.0",
+  "wechaty": "^0.60.3",
+}


We should change adding dependencies way from adding to package.json to using npm install

maybe change something like this:

npm install wechaty

If you want to show qr-code at the terminal, you can add this:

npm install qrcode- terminal

We may not use dotenv here because this is not the requisite package when using wechaty

lijiarui · 2021-07-06T17:19:53Z

+  "wechaty-puppet-wechat4u": "^0.18",
+  "wechaty-puppet-whatsapp": "0.2.3"
+}
+```


We should change adding dependencies way from adding to package.json to using npm install

may change something like this:

You can install wechaty-puppet as you like when using wechaty:

If young want to use whatsapp,you can install wechaty-puppet-whatsapp

npm install wechaty-puppet-whatsapp

If you want to use wechat, you can install wechaty-puppet-wechat

npm install wechaty-puppet-wechat

If you want to use wecom, you can install wechaty-puppet-wxwork

npm install wechaty-puppet-wxwork

You can find more puppet information here: https://wechaty.js.org/docs/puppet-providers/

lijiarui · 2021-07-06T17:20:34Z

+    "wechaty-puppet-mock": "^0.28.2",
+    "wechaty-puppet-wechat": "^0.28",
+    "wechaty-puppet-wechat4u": "^0.18",
+    "wechaty-puppet-whatsapp": "0.2.3"


We can delete this pakcage.json part, since it is not necessary for users.

deleted package.json

lijiarui · 2021-07-06T17:21:06Z

+
+```sh
+npm install
+```


Reomve npm install here, because we already use npm install XXX before

lijiarui · 2021-07-06T17:28:21Z

+
+### 6. Defining scripts
+
+You have to define the script for running the bot. Add the following to your `package.json` file:


This is an enhancement feature, I'd rather to remove this from the tutorial. If you strongly want to add it here, maybe you can tell the reader about this.

We can change this something like this:

If you want to run it more conveniently, you can add some script in package.json.

lijiarui · 2021-07-06T17:36:49Z

I think you can refer to this PR when telling people how to use wechaty: https://github.com/wechaty/wechaty.js.org/pull/905

shwetalsoni · 2021-07-07T11:37:07Z

@lijiarui I have applied all the requested changes except the code sandbox. I have attached screenshots for clearance.
@sbis04 Can you please help me with code sandbox error. I tried but couldn't fix it.

lijiarui

Good job!

One more tips to fix.

lijiarui · 2021-07-07T16:20:53Z

+
+```sh
+npm install -g npx
+```


Please remove npm install npx here, because node has npx itself.

lijiarui · 2021-07-07T16:23:04Z

@lijiarui I have applied all the requested changes except the code sandbox. I have attached screenshots for clearance.
@sbis04 Can you please help me with code sandbox error. I tried but couldn't fix it.

@sbis04 you can click here: https://codesandbox.io/s/github/wechaty/wechaty-getting-started/tree/master/examples/third-parties/codesandbox?hidenavigation=1&module=%2Fding-dong-bot.ts&theme=dark and will found error as well. Pls help @shwetalsoni fix this.

…rg into running-locally

shwetalsoni · 2021-07-07T16:34:24Z

@lijiarui I have applied the above requested change.

lijiarui · 2021-07-07T18:34:23Z

Good job, I think you can file a new issue about the sandbox problem, and I will approve this PR.

shwetalsoni · 2021-07-07T18:36:38Z

Good job, I think you can file a new issue about the sandbox problem, and I will approve this PR.

Do you mean to create an issue under Issues?

shwetalsoni · 2021-07-08T08:24:32Z

@lijiarui I have created issue #1032 for keeping the record of all the features that need to be added later mentioning all the respective PR's.

shwetalsoni added 10 commits May 23, 2021 22:07

running ding-dong-bot locally

5a8cb7f

0.8.281

8b57a14

0.8.282

8e3c9a4

Merge branch 'master' of https://github.com/wechaty/wechaty.js.org in…

8b15060

…to running-locally

0.8.284

8ec9534

0.8.285

b1419e9

0.8.286

b1fe14c

0.8.287

5ff6cfb

0.8.288

6bd3307

0.8.289

71dd3d2

shwetalsoni requested a review from a team as a code owner May 23, 2021 17:23

shwetalsoni requested review from Rohitesh-Kumar-Jain, huan, proudofsimin and sbis04 May 23, 2021 17:26

shwetalsoni added GSoD 2021 tutorials Related to tutorial docs labels May 23, 2021

shwetalsoni mentioned this pull request May 24, 2021

Update and improve Tutorials section #891

Closed

33 tasks done

shwetalsoni added 9 commits May 25, 2021 11:52

added codesandbox

81b8496

0.8.290

a91f59a

Merge branch 'master' of https://github.com/wechaty/wechaty.js.org in…

1bd8c1b

…to running-locally

0.8.286

6495ee2

0.8.287

049db3f

solving conflicts

db10379

0.8.290

b16d2d5

problem with version

a5ee011

0.8.292

2980df0

lijiarui mentioned this pull request Jul 6, 2021

GSoD Merging List #1026

Closed

Merge branch 'master' into running-locally

dd33079

lijiarui requested changes Jul 6, 2021

View reviewed changes

This was referenced Jul 6, 2021

Updated tutorial overview as per suggestion with a new PR #934

Merged

Getting started overview #935

Merged

added tutorial for qr-code-terminal plugin #969

Merged

changed file name, modified dependencies section

6a3838f

shwetalsoni requested a review from a team as a code owner July 7, 2021 11:11

fix style

a82e3c3

shwetalsoni and others added 2 commits July 7, 2021 17:23

fixing links

e3f1e78

Merge branch 'master' into running-locally

7f523ea

lijiarui requested changes Jul 7, 2021

View reviewed changes

shwetalsoni added 2 commits July 7, 2021 21:56

removed npx cmd

49d6216

Merge branch 'running-locally' of github.com:shwetalsoni/wechaty.js.o…

2e8f62a

…rg into running-locally

lijiarui mentioned this pull request Jul 7, 2021

Improve and update Vorpal bot steps #882

Merged

lijiarui approved these changes Jul 7, 2021

View reviewed changes

shwetalsoni mentioned this pull request Jul 8, 2021

Features to be added later to tutorials section #1032

Closed

7 tasks done

huan approved these changes Jul 8, 2021

View reviewed changes

Merge branch 'master' into running-locally

039c58d

lijiarui merged commit bf61c15 into wechaty:master Jul 8, 2021

lijiarui added a commit that referenced this pull request Jul 8, 2021

make github action green for #888

6b05f4c

sbis04 mentioned this pull request Jul 10, 2021

Update tutorials running locally page #1042

Merged


		### 6. Defining scripts

		You have to define the script for running the bot. Add the following to your `package.json` file:

Conversation

shwetalsoni commented May 23, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

shwetalsoni commented May 24, 2021

Uh oh!

Rohitesh-Kumar-Jain commented May 25, 2021

Uh oh!

shwetalsoni commented May 25, 2021 via email

Uh oh!

lijiarui left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

1. change the file name

2. Fix CodeSandbox error

Uh oh!

lijiarui left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

lijiarui commented Jul 6, 2021

Uh oh!

shwetalsoni commented Jul 7, 2021

Uh oh!

lijiarui left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

lijiarui commented Jul 7, 2021

Uh oh!

shwetalsoni commented Jul 7, 2021

Uh oh!

lijiarui commented Jul 7, 2021

Uh oh!

shwetalsoni commented Jul 7, 2021

Uh oh!

shwetalsoni commented Jul 8, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

shwetalsoni commented May 23, 2021 •

edited

Loading

lijiarui left a comment •

edited

Loading