Repository navigation
Overview sub-section of the Introduction section - #870
Conversation
Overview sub-section of the Introduction section By Joseph Mawa
nibble0101
changed the title
proudofsimin
left a comment
proudofsimin
left a comment
There was a problem hiding this comment.
Hi @nibble0101,
Overall this is a very great document! I left some comments below and also reference of Google style. Feel free to let me know if you have any question.
|
@proudofsimin Thank you very much for your comments to improve this PR, I believe they are very valuable. We should strictly follow the Documentation System for our docs contributing, @nibble0101 please follow the suggestions from @proudofsimin and make sure all our docs can be adaptered to the Documentation System, appreciate it! |
…0101/wechaty.js.org into overview-of-wechaty-documentation
|
I don't think CI is failing because of the commit I made above. |
Yes, it's not related to this PR. Sorry for that, I'm fixing it now. |
proudofsimin
left a comment
proudofsimin
left a comment
There was a problem hiding this comment.
Hi @nibble0101,
Wow I love it so much! Please correct just three minor typos. Thank you.
…0101/wechaty.js.org into overview-of-wechaty-documentation
nibble0101
added
the
introduction
Rohitesh-Kumar-Jain
left a comment
Rohitesh-Kumar-Jain
left a comment
There was a problem hiding this comment.
Great work guys, and thanks for fixing the typos
ping @huan
…ion of the Introduction section
…0101/wechaty.js.org into overview-of-wechaty-documentation
|
@nibble0101 Please resolve the conflict first. And @Rohitesh-Kumar-Jain As GSoD Project PR Review Rules in https://github.com/wechaty/wechaty.js.org/issues/1045 This PR should follow our rules and get enough approval, then I will review this PR. So I remove the |
|
@chris-4444 I would like you to once go through the PR, and approve when you think it's ready to get merged. |
Updated.
lijiarui
left a comment
lijiarui
left a comment
There was a problem hiding this comment.
Thanks for updating!
I think the whole file looks good to me, but I suggest we add the link in the page, or file an issue to track this, then adding the issue in the future, or it may cause a dead link in the future.
Also, I file an issue #1089 and looking forward to put the content somewhere in the doc in the future.
|
Thank you very much for all efforts from everyone as a team, appreciate it! |
6 participants
Improve the Introduction and Explanations project
This the Overview sub-section of the Introduction section