Skip to content

fix(highlight): screen highlight clipping on macOS #237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
webadderall merged 1 commit into from
Apr 27, 2026
Merged

fix(highlight): screen highlight clipping on macOS #237

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions electron/ipc/recording/ffmpeg.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,14 @@ export function getDisplayBoundsForSource(source: SelectedSource) {
).bounds;
}

export function getDisplayWorkAreaForSource(source: SelectedSource) {
const allDisplays = getScreen().getAllDisplays();
const primaryDisplay = getScreen().getPrimaryDisplay();
const { displayId } = resolveWindowsCaptureDisplay(source, allDisplays, primaryDisplay);
const matched = allDisplays.find((d) => d.id === displayId) ?? primaryDisplay;
return matched.workArea;
}

export async function buildFfmpegCaptureArgs(source: SelectedSource, outputPath: string) {
const commonOutputArgs = [
"-an",
Expand Down
23 changes: 18 additions & 5 deletions electron/ipc/register/sources.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import { ALLOW_RECORDLY_WINDOW_CAPTURE } from "../constants";
import { selectedSource, setSelectedSource } from "../state";
import type { SelectedSource } from "../types";
import { getScreen, parseWindowId } from "../utils";
import { getDisplayBoundsForSource } from "../recording/ffmpeg";
import { getDisplayBoundsForSource, getDisplayWorkAreaForSource } from "../recording/ffmpeg";
import {
getNativeMacWindowSources,
resolveMacWindowBounds,
Expand Down Expand Up @@ -337,7 +337,10 @@ export function registerSourceHandlers({
let bounds: { x: number; y: number; width: number; height: number } | null = null;

if (source.id?.startsWith("screen:")) {
bounds = getDisplayBoundsForSource(source);
bounds =
process.platform === "darwin"
? getDisplayWorkAreaForSource(source)
: getDisplayBoundsForSource(source);
} else if (isWindow) {
if (process.platform === "darwin") {
bounds = await resolveMacWindowBounds(source);
Expand All @@ -363,7 +366,12 @@ export function registerSourceHandlers({
const resolvedBounds = bounds;

// ── 3. Show traveling wave highlight ──
const pad = 6;
// On macOS, screen highlights use workArea and no outward padding —
// macOS clamps window positions below the menu bar so outward
// padding only works on the left/top while right/bottom run off-screen.
const isScreen = source.id?.startsWith("screen:");
const isMacScreen = isScreen && process.platform === "darwin";
const pad = isMacScreen ? 0 : 6;
const highlightWin = new BrowserWindow({
x: resolvedBounds.x - pad,
y: resolvedBounds.y - pad,
Expand All @@ -381,13 +389,18 @@ export function registerSourceHandlers({

highlightWin.setIgnoreMouseEvents(true);

const borderRadius = isMacScreen ? 0 : 10;
const glowInset = isMacScreen ? 0 : -4;
const glowRadius = isMacScreen ? 0 : 14;
const glowPad = isMacScreen ? 3 : 6;

const html = `<!DOCTYPE html>
<html><head><style>
*{margin:0;padding:0;box-sizing:border-box}
body{background:transparent;overflow:hidden;width:100vw;height:100vh}

.border-wrap{
position:fixed;inset:0;border-radius:10px;padding:3px;
position:fixed;inset:0;border-radius:${borderRadius}px;padding:3px;
background:conic-gradient(from var(--angle,0deg),
transparent 0%,
transparent 60%,
Expand All @@ -405,7 +418,7 @@ body{background:transparent;overflow:hidden;width:100vw;height:100vh}
}

.glow-wrap{
position:fixed;inset:-4px;border-radius:14px;padding:6px;
position:fixed;inset:${glowInset}px;border-radius:${glowRadius}px;padding:${glowPad}px;
background:conic-gradient(from var(--angle,0deg),
transparent 0%,
transparent 65%,
Expand Down