enhance the simd advisor - #61
Merged
Merged
Conversation
- x86 intrinsic header file is included - compiler flags should be added when SSE intrinsics are included
lingyuncai
reviewed
Feb 7, 2024
lingyuncai
left a comment
lingyuncai
left a comment
Contributor
There was a problem hiding this comment.
Thanks Ning! Please add a test case for the enhanced scenario, together with the PR :)
Contributor
Author
Test cases updated. PTAL~ |
lingyuncai
reviewed
Feb 7, 2024
| actions.push(action); | ||
| } | ||
| } | ||
|
|
Contributor
There was a problem hiding this comment.
Maybe we should also check the simd option value to determine if we need to enable the simd option at the same time when actions array is not empty.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
to handle the scenarios
to close #56