Repository navigation
fix(gauntlet): print each failing file's failing rows in the closing summary (GH #158) - #503
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #158 (stays open: the flake itself is not fixed, only made diagnosable). A failed gauntlet now prints up to 3 failing rows per failing test file as
failed-at: <file>: <row>lines before the closingfailing:list (still the last line). A file with no marked row (a crash) shows its last output line. Asked for in the #158 thread so a load flake can be told from a regression without a re-run. Test: tests/scripts/test-gauntlet-failed-summary.sh, 3 new rows (failed first).