Repository navigation
feat(audit): check 79 pins doc facts to the tree; README lists all 10 gates (#388) - #401
Merged
Merged
Conversation
… gates (GH #388) Check 79 compares prose facts to values the tree derives: the manifest gate count and README gate table vs hook-registry.json gate ids, README Skills/Agents counts and the agent-doc fleet size vs the tree, the harness-audit check table vs audit.sh _exp_ids, and the marketplace entry version vs plugin.json. WARN on mismatch or when a pinned phrase vanishes. Live run caught README missing gate:tool:routine-trigger-guard; the row is added here. Closes #388
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
skills/meta/harness-audit/scripts/checks/79-doc-facts-match-tree.sh). It compares prose facts to values taken from the tree:hooks/hook-registry.json, with-handbacktwins dropped.Skills (N)must equal the SKILL.md count minusMANIFEST_EXPECTED_EXCLUDED. READMEAgents (N)andagent-authoring-conventions.md's "N-agent fleet" must equal theagents/*.mdcount.audit.sh_exp_ids. Only an id at the start of a segment counts, so25 wordsand1536 charsare not read as ids..versionmust equal the marketplace.json entry's version.gate:tool:routine-trigger-guard, so it lists all 10 gates._exp_idsand in SKILL.md's check table (Doc rot row). The test header now lists 79. The fleet-good manifest gained a description that carries the pinned phrase.Why
The README listed 9 of the 10 gates and has never named routine-trigger-guard since that gate landed (1.1.151). This is the second time a stated count has drifted (CHANGELOG records an earlier "6 gates" drift), so per the repeated-mistake rule it gets a check.
Proof
check-79-*) and their asserts before the check existed. The self-test went red with 18 FAIL, because--only 79matched no fragment.self-test: 144 passed, 0 failed.WARN: README.md gate table lacks gate:tool:routine-trigger-guard (in hooks/hook-registry.json). After the fix: 0 WARN.audit.sh: 0 CRIT, 0 WARN.GAUNTLET_JOBS=2 scripts/run-gauntlet.sh: all layers passed.No manifest bump.
Closes #388