Repository navigation
fix(gauntlet): name failing test files in the log tail (GH #387) - #399
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
run_hook_tests()collects every test file with a non-zero exit and printsfailing: <files>after the layer's output.gauntlet: FAILEDmessage repeats that line, so the last lines of a CI log name the culprit.tests/scripts/test-gauntlet-failed-summary.sh.Why
A red gauntlet log never named the failing file. One CI failure log ran to 3284 lines in 49 sections, and the runner's /tmp, where the full logs are kept, is gone after the job.
Proof
run_hook_tests()withhook_test_files()stubbed to one passing and one failing fixture, and runs the script's closing if-block on a fixture log. Red before the fix (2/4 failed), green after (4/4).test-run-gauntlet-wiring.shandtest-gauntlet-log-preservation.shpass.audit.sh: 0 CRIT.run-gauntlet.sh: all layers passed.Closes #387