Repository navigation
test(gates): retry a timing row once so a load spike is not a failure (GH #158) - #304
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #158
While landing six gate fixes today,
test-subagent-git-guard.shfailed on two 8 s timing rows (rc 124) when peer sessions ran gauntlets at the same time (load average 35-70). Each passed when rerun alone, and none of the changes touched them. This looks like the flake class in #158.The rows exist to catch a quadratic scan that runs past the hook's 8 s timeout. A load spike can push a fast row past 8 s once; a real slowdown takes 9 s or more every time. So
sgg_rc8and the 2 MB-run row now retry once on a timeout and fail only if both runs time out.Test-only change. test-subagent-git-guard 427/427. The original #158 failure was never recovered, so this does not claim to close it; the issue stays open for that.