Repository navigation
fix(v3/linux): align cross image GTK baseline - #5941
Conversation
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
WalkthroughThe cross-compilation image now uses Debian 13 and validates GTK 4.14, WebKitGTK 6.0, GTK 3, and WebKitGTK 4.1 development packages. Tests and documentation record these requirements. ChangesCross-image GTK baseline
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@IMPLEMENTATION.md`:
- Around line 243-246: Update the Phase 6 instructions near the canonical
Dockerfile.cross description so they state GTK4 is the default backend and the
legacy path is selected with -tags gtk3. Remove or clearly mark outdated
GTK3-default and BUILD_TAGS=gtk4 guidance as historical, keeping
IMPLEMENTATION.md consistent with the current GTK4/GTK3 contract.
In `@v3/internal/commands/cross_dockerfile_test.go`:
- Around line 15-25: Extend the Dockerfile content assertions in the cross-image
test to verify the three missing pkg-config checks: webkitgtk-6.0, gtk+-3.0, and
webkit2gtk-4.1, alongside the existing GTK4 assertion. Keep the current
dependency-package assertions unchanged.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: 18b46200-1f4f-4d78-8906-52f91a719a2e
📒 Files selected for processing (4)
IMPLEMENTATION.mdv3/UNRELEASED_CHANGELOG.mdv3/internal/commands/build_assets/docker/Dockerfile.crossv3/internal/commands/cross_dockerfile_test.go
|
Addressed both actionable CodeRabbit findings in
Verification:
The installed CodeRabbit CLI rejects the legacy |
* fix(v3/linux): align cross image GTK baseline * test(v3/linux): cover cross image package checks --------- Co-authored-by: Lea Anthony <lea.anthony@gmail.com>
Fixes #5928
Root cause
The canonical cross image used Debian 12, whose GTK 4.8 headers do not provide the GTK APIs used by the default Wails v3 Linux backend.
Change
-tags gtk3pathVerification
./pkg/applicationon Trixie (GTK 4.18.6), default GTK4 path./pkg/applicationon Trixie with-tags gtk3CGO_ENABLED=0 go test ./internal/commands -run TestCrossDockerfileMatchesLinuxSupportContract -count=1git diff --checkSummary by CodeRabbit
Bug Fixes
Documentation