Repository navigation
Add backticks to format inline command - #5652
osmanbowser wants to merge 1 commit into
Conversation
Previously, it wasn't clear that `wails init...` was an inline command
WalkthroughTwo ChangesDocs Inline Code Fix
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
website/versioned_docs/version-v2.12.0/gettingstarted/firstproject.mdx (1)
31-35: 🧹 Nitpick | 🔵 Trivial | ⚡ Quick winConsider applying consistent backtick formatting to all framework tabs.
The Svelte examples now use inline backticks for the
wails initcommands, but the React, Vue, Preact, Lit, and Vanilla tabs (lines 41, 45, 51, 55, 61, 65, 71, 75, 81, 85) still use plain text. For consistency across the entire tabbed section and alignment with broader documentation conventions, consider wrapping allwails initcommands in backticks.✨ Example: Formatting the React tab for consistency
<TabItem value="React"> Generate a <a href={"https://reactjs.org/"}>React</a> project using JavaScript with:<br/><br/> - wails init -n myproject -t react + `wails init -n myproject -t react` If you would rather use TypeScript:<br/> - wails init -n myproject -t react-ts + `wails init -n myproject -t react-ts`Apply the same pattern to Vue, Preact, Lit, and Vanilla tabs.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@website/versioned_docs/version-v2.12.0/gettingstarted/firstproject.mdx` around lines 31 - 35, The Svelte framework tab currently uses inline backticks for the wails init commands, but the React, Vue, Preact, Lit, and Vanilla tabs use plain text formatting. Apply consistent backtick formatting by wrapping all wails init command examples in backticks across every framework tab (React, Vue, Preact, Lit, Vanilla, and Svelte) to maintain uniformity throughout the documentation and align with broader documentation conventions.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@website/versioned_docs/version-v2.12.0/gettingstarted/firstproject.mdx`:
- Around line 31-35: The Svelte framework tab currently uses inline backticks
for the wails init commands, but the React, Vue, Preact, Lit, and Vanilla tabs
use plain text formatting. Apply consistent backtick formatting by wrapping all
wails init command examples in backticks across every framework tab (React, Vue,
Preact, Lit, Vanilla, and Svelte) to maintain uniformity throughout the
documentation and align with broader documentation conventions.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 0a7424a5-0db5-49dc-b895-e88394bda358
📒 Files selected for processing (1)
website/versioned_docs/version-v2.12.0/gettingstarted/firstproject.mdx
|
I opened #5653 to fix this for every web framework, not just Svelte. |
Previously, it wasn't clear that
wails init...was an inline commandDescription
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
Add backticks to inline commands for clarity.
Type of change
Please select the option that is relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration using
wails doctor.If you checked Linux, please specify the distro and version.
Test Configuration
Please paste the output of
wails doctor. If you are unable to run this command, please describe your environment in as much detail as possible.I don't believe this is necessary. But if it is, please advise.
Checklist:
website/src/pages/changelog.mdxwith details of this PR (v3 changelog entries are added automatically)Summary by CodeRabbit