Skip to content

fix(v3/darwin): make RelativePosition mirror SetRelativePosition on both axes #5569

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
leaanthony merged 5 commits into from
Jun 13, 2026
Merged

fix(v3/darwin): make RelativePosition mirror SetRelativePosition on both axes #5569

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c5520db
fix(v3/darwin): make RelativePosition mirror SetRelativePosition on b…
leaanthony Jun 10, 2026
bb3734d
chore: merge master into fix/darwin-relative-position-5408, resolve c…
leaanthony Jun 13, 2026
c858a7d
fix(v3/darwin): clarify windowGetRelativePosition comment
leaanthony Jun 13, 2026
2160c50
Merge remote-tracking branch 'origin/master' into fix/darwin-relative…
leaanthony Jun 13, 2026
f3970eb
chore: remove UNRELEASED_CHANGELOG.md to avoid merge conflicts
leaanthony Jun 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions v3/pkg/application/webview_window_darwin.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -620,19 +620,25 @@ int windowGetHeight(void* nsWindow) {
return [(WebviewWindow*)nsWindow frame].size.height;
}

// Get window position
// Get the window position relative to its screen's NSScreen frame origin:
// X from the screen's left edge, Y from the screen's top edge (Y-down).
// Uses NSScreen frame (full extent, including menu bar/dock) rather than
// visibleFrame. Must mirror windowSetRelativePosition exactly so Get/Set
// round-trip on every screen: previously X was returned absolute (missing
// the screenFrame.origin.x subtraction) and Y omitted screenFrame.origin.y,
// so each axis was wrong only on screens whose corresponding NSScreen
// frame.origin component is non-zero (issue #5408).
void windowGetRelativePosition(void* nsWindow, int* x, int* y) {
WebviewWindow* window = (WebviewWindow*)nsWindow;
NSRect frame = [window frame];
*x = frame.origin.x;

// Translate to screen coordinates so Y=0 is the top of the screen
NSScreen* screen = [window screen];
if( screen == NULL ) {
screen = [NSScreen mainScreen];
}
NSRect screenFrame = [screen frame];
*y = screenFrame.size.height - frame.origin.y - frame.size.height;
*x = frame.origin.x - screenFrame.origin.x;
*y = (screenFrame.origin.y + screenFrame.size.height) - frame.origin.y - frame.size.height;
}

// Get absolute window position in the canonical Wails coordinate space:
Expand Down
Loading