fix(v3/examples): rename build/build/ → build/assets/ to fix go build . collision - #5401
Conversation
…sion The example lives in v3/examples/build/, so `go build .` tried to create a binary named `build` — blocked by the existing build/ subdirectory. Rename the subdirectory to assets/ (matching 22 other v3 examples) to eliminate the collision and add a README note guiding users to the Taskfile or an explicit -o flag.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (2)
📒 Files selected for processing (7)
WalkthroughThe example project's build system is reorganized to consolidate artifacts into an ChangesBuild Output Directory Consolidation
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…es): rename build/build/ → build/assets/ to fix `go build .` collision
Problem
Running
go build .insidev3/examples/build/fails with:The example directory is named
build, so Go's default binary output is also namedbuild— blocked by the existingbuild/subdirectory containing icons, plist files, etc.Fix
Rename
v3/examples/build/build/→v3/examples/build/assets/to match the convention used by 22 other v3 examples (binding,events,window,dialogs, etc.). Update all references inTaskfile.ymland add a README note directing developers to usewails3 task buildorgo build -o bin/buildtest ..Changes
v3/examples/build/build/→v3/examples/build/assets/(7 files renamed)Taskfile.yml: alldir: buildandbuild/bin/references updated toassetsREADME.md: added note about the barego build .limitationCloses #5391
Summary by CodeRabbit
Documentation
Chores