Repository navigation
chore(workflows): audit — add path filters, drop dead workflows - #5280
Merged
Merged
Conversation
Now that v2 and v3 share master, every push fires both v2 and v3
test suites unless we narrow the triggers. This audit pass:
Path filters added so each workflow only runs when its scope changes:
- build-and-test.yml -> v2/**
- build-and-test-v3.yml -> v3/**
- cross-compile-test-v3.yml -> v3/**
- publish-npm.yml -> v3/internal/runtime/desktop/@wailsio/runtime/**
- upload-source-documents.yml -> website/docs/**
(each also includes its own .yml so workflow edits still trigger.)
Workflows deleted (dead, redundant, or broken):
- runtime.yml — triggered on push to v2-alpha, a branch
that never existed; dead since 2022.
- projects.yml — uses project_card event (legacy GitHub
Projects classic); never fires.
- test-simple.yml — debug placeholder, only echoes "Hello World".
- automated-releases.yml — fails on every push and is redundant with
nightly-release-v3.yml (both publish v3
alpha releases). Keeping the simpler one.
- claude-code-review.yml — depends on an ANTHROPIC_API_KEY secret
that isn't configured; fails on every PR.
Other fixes:
- semgrep.yml: drop `- main` from the branches list (this repo's
default branch is master; `main` doesn't exist).
Known follow-up not in this PR:
- unreleased-changelog-trigger.yml is failing on every push but with
zero job output — likely a YAML/permissions issue at the run-attempt
layer. Needs separate investigation.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
pull Bot
pushed a commit
to oi2996814/wails
that referenced
this pull request
Apr 29, 2026
…ws): audit — add path filters, drop dead workflows
Contributor
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (11)
WalkthroughThis PR modifies GitHub Actions workflows by deleting 5 unused workflows and adding path-based trigger constraints to 6 others to limit execution to relevant file changes. One workflow also removes an obsolete branch from its trigger conditions. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Poem
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Review rate limit: 7/8 reviews remaining, refill in 7 minutes and 30 seconds.Comment |
Contributor
There was a problem hiding this comment.
Pull request overview
Audits GitHub Actions workflows after the v3-alpha → master merge to reduce unnecessary CI runs by scoping workflows to relevant paths and removing dead/redundant workflows.
Changes:
- Added
pathsfilters to several workflows so they only trigger when their corresponding areas change. - Removed multiple obsolete/broken workflows that no longer run or are redundant.
- Updated
semgrep.ymlto stop targeting the non-defaultmainbranch.
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| .github/workflows/upload-source-documents.yml | Adds path scoping for the Crowdin source upload workflow. |
| .github/workflows/test-simple.yml | Removes a placeholder “Hello World” workflow. |
| .github/workflows/semgrep.yml | Removes main from push branches, leaving master. |
| .github/workflows/runtime.yml | Removes a dead workflow targeting a non-existent branch. |
| .github/workflows/publish-npm.yml | Adds path scoping for the v3 runtime npm publish workflow. |
| .github/workflows/projects.yml | Removes a deprecated GitHub Projects (classic) workflow. |
| .github/workflows/cross-compile-test-v3.yml | Adds path scoping for the v3 cross-compile workflow. |
| .github/workflows/claude-code-review.yml | Removes a workflow dependent on unconfigured secrets. |
| .github/workflows/build-and-test.yml | Adds path scoping for the v2 build/test workflow. |
| .github/workflows/build-and-test-v3.yml | Adds path scoping for the v3 build/test workflow. |
| .github/workflows/automated-releases.yml | Removes a redundant/broken automated release workflow. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
4
to
+10
| pull_request_review: | ||
| types: [submitted] | ||
| branches: | ||
| - master | ||
| paths: | ||
| - 'v3/**' | ||
| - '.github/workflows/cross-compile-test-v3.yml' |
| push: | ||
| branches: [master] | ||
| paths: | ||
| - 'website/docs/**' |
| push: | ||
| branches: ['master'] | ||
| paths: | ||
| - 'v3/internal/runtime/desktop/@wailsio/runtime/**' |
9 of 11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
First-pass workflow audit after the v3-alpha → master merge. Now that v2 and v3 share
master, every push or PR fires both v2 and v3 pipelines unless we narrow the triggers. Plus several workflows were dead, redundant, or broken.Path filters added
Each of these now only fires when its scope actually changes (each list also includes the workflow's own
.ymlso edits to the workflow trigger a re-run):build-and-test.ymlv2/**build-and-test-v3.ymlv3/**cross-compile-test-v3.ymlv3/**publish-npm.ymlv3/internal/runtime/desktop/@wailsio/runtime/**upload-source-documents.ymlwebsite/docs/**Workflows deleted
runtime.ymlv2-alpha— a branch that never existed; dead since 2022projects.ymlproject_cardevent from deprecated GitHub Projects (classic); never firestest-simple.ymlautomated-releases.ymlnightly-release-v3.ymlclaude-code-review.ymlANTHROPIC_API_KEYsecret that isn't configured; fails on every PROther fixes
semgrep.yml— drop- mainfrom the branches list (this repo's default branch ismaster)Known follow-up
unreleased-changelog-trigger.ymlis failing on every push with zero job output — looks like a YAML/permissions issue at the run-attempt layer. Needs separate investigation. The intent (auto-trigger nightly-release-v3 whenv3/UNRELEASED_CHANGELOG.mdupdates) is still wanted, just not fixed in this PR.Test plan
v2/...triggersBuild + Test v2and not v3 jobs.v3/...triggersBuild + Test v3and not v2 jobs.website/docs/...triggersUpload Source Documents(after merge) andpr-master.ymlchecks.🤖 Generated with Claude Code
Summary by CodeRabbit