Repository navigation
I am requesting to add this new template for react - #5239
RProduction wants to merge 1 commit into
Conversation
New template for react with typescript, tailwindcss, and react-router in framework mode.
📝 WalkthroughWalkthroughThis pull request adds a single React community template entry to the existing templates documentation file, expanding the available template examples in the React section with a new GitHub link and brief description. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
website/docs/community/templates.mdx (1)
48-48: Standardize framework names/casing in the description.Please align wording with existing docs style: use
TypeScriptandTailwindCSS(instead ofTypescript/TailwindCss), and considerReact Router (Framework mode)for clarity.Suggested doc tweak
-- [wails-template-react-ts-tailwind-routerframework](https://github.com/RProduction/wails-template-react-ts-tailwind-routerframework) - A template for React with Typescript, TailwindCss, React Router Framework mode. +- [wails-template-react-ts-tailwind-routerframework](https://github.com/RProduction/wails-template-react-ts-tailwind-routerframework) - A template for React with TypeScript, TailwindCSS, and React Router (Framework mode).🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@website/docs/community/templates.mdx` at line 48, Update the description for the template named "wails-template-react-ts-tailwind-routerframework": standardize casing and wording to use "TypeScript" and "TailwindCSS" and clarify router wording as "React Router (Framework mode)"; replace the existing phrase "React with Typescript, TailwindCss, React Router Framework mode" with "React with TypeScript, TailwindCSS, React Router (Framework mode)" so it matches the docs style.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@website/docs/community/templates.mdx`:
- Line 48: Update the description for the template named
"wails-template-react-ts-tailwind-routerframework": standardize casing and
wording to use "TypeScript" and "TailwindCSS" and clarify router wording as
"React Router (Framework mode)"; replace the existing phrase "React with
Typescript, TailwindCss, React Router Framework mode" with "React with
TypeScript, TailwindCSS, React Router (Framework mode)" so it matches the docs
style.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: ca03b877-90e7-4faa-842a-5e089f331668
📒 Files selected for processing (1)
website/docs/community/templates.mdx
|
🤖 PR Triage Review ❓ Comment and Wait This PR requests to add a new React template. I need more information:
Please provide more context so I can properly evaluate this PR. Reviewed by Wails PR Reviewer Bot |
|
Thanks for contributing! This PR adds a reference to a React template in the community templates documentation. A few questions to help me review this:
Once you clarify these points, I can proceed with the review. |
|
Thanks for contributing this template! A few questions before we can proceed:
Please provide more details and cross-platform testing results. |
|
This PR is behind the master branch. Please rebase your branch on the latest master. Also, please provide:
To rebase: git fetch upstream master
git rebase upstream/master
git push --force-with-lease |
|
Thanks for contributing! Community templates are great, but I have a few questions:
Please update your testing checklist to include all supported platforms and provide more information about the template itself. |
|
Thanks for wanting to contribute a community template! Before I can proceed with reviewing this, I need some additional information:
Decision: COMMENT-AND-WAIT - Awaiting additional information CC @leaanthony |
leaanthony
left a comment
There was a problem hiding this comment.
Thanks! Just one small fix needed: please capitalise TailwindCss as TailwindCSS in the template entry text, to match the style of other entries in the list. Happy to merge once that's corrected.
|
Sorry for not watching the pull request I made myself. You can reject the pull request, I have tested it at some point, and there is some error, and have problem when updating the package at first. |
New template for react with typescript, tailwindcss, and react-router in framework mode.
I updated the templates.mdx with my template
Description
I am adding new template in community template page.
It is react template with typescript, tailwindcss, react-router framework mode for wails v2.
Type of change
Please select the option that is relevant.
How Has This Been Tested?
I have tested the template locally, and by using github repo.
Test Configuration
Please paste the output of
wails doctor. If you are unable to run this command, please describe your environment in as much detail as possible.Checklist:
website/src/pages/changelog.mdxwith details of this PRSummary by CodeRabbit