Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 12 additions & 5 deletions .github/workflows/pr-master.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ jobs:
if: ${{ github.repository == 'wailsapp/wails' && github.base_ref == 'master' }}
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4

- name: Verify Changed files
uses: step-security/changed-files@3dbe17c78367e7d60f00d78ae6781a35be47b4a1 # v45.0.1
Expand Down Expand Up @@ -59,20 +59,27 @@ jobs:

steps:
- name: Checkout code
uses: actions/checkout@v3
uses: actions/checkout@v4

- name: Install linux dependencies (22.04)
uses: awalsh128/cache-apt-pkgs-action@latest
if: matrix.os == 'ubuntu-22.04'
run: sudo apt-get update -y && sudo apt-get install -y libgtk-3-dev libwebkit2gtk-4.0-dev build-essential pkg-config
with:
packages: libgtk-3-dev libwebkit2gtk-4.0-dev build-essential pkg-config
version: 1.0
Comment on lines 64 to +69

Copilot AI Apr 14, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awalsh128/cache-apt-pkgs-action is referenced via the mutable @latest tag. This can introduce supply-chain risk and make CI non-deterministic if the action changes or is re-published. Prefer pinning to an immutable ref (a release tag like @v1 if maintained, or a commit SHA) and bump intentionally when upgrading.

Copilot uses AI. Check for mistakes.

- name: Install linux dependencies (24.04)
uses: awalsh128/cache-apt-pkgs-action@latest
if: matrix.os == 'ubuntu-24.04'
run: sudo apt-get update -y && sudo apt-get install -y libgtk-3-dev libwebkit2gtk-4.1-dev build-essential pkg-config
with:
packages: libgtk-3-dev libwebkit2gtk-4.1-dev build-essential pkg-config

Copilot AI Apr 14, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Ubuntu 24.04 dependency list here differs from the v2 build-and-test.yml workflow (which also installs libegl1 on 24.04). This drift can lead to PR checks passing while the main build workflow fails (or vice versa). Consider aligning the package list between the workflows, or add a short note explaining why pr-master.yml intentionally installs a different set.

Suggested change
packages: libgtk-3-dev libwebkit2gtk-4.1-dev build-essential pkg-config
packages: libgtk-3-dev libwebkit2gtk-4.1-dev libegl1 build-essential pkg-config

Copilot uses AI. Check for mistakes.
version: 1.0

- name: Setup Go
uses: actions/setup-go@v3
uses: actions/setup-go@v5
with:
go-version: ${{ matrix.go-version }}
cache-dependency-path: v2/go.sum

- name: Run tests (mac)
if: matrix.os == 'macos-latest'
Expand Down
Loading