Skip to content

Fix GitHub template - #5109

Merged
leaanthony merged 4 commits into
wailsapp:masterfrom
wayneforrest:fix-github-template
May 2, 2026
Merged

leaanthony merged 4 commits into
wailsapp:masterfrom
wayneforrest:fix-github-template

Conversation

@wayneforrest

@wayneforrest wayneforrest commented Apr 2, 2026 •

Copy link
Copy Markdown
Contributor

Fixes #5108

#5108

Type of change

Please select the option that is relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration using wails doctor.

  • Windows
  • macOS
  • Linux

If you checked Linux, please specify the distro and version.

Test Configuration

Please paste the output of wails doctor. If you are unable to run this command, please describe your environment in as much detail as possible.

Checklist:

  • I have updated website/src/pages/changelog.mdx with details of this PR
  • My code follows the general coding style of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Summary by CodeRabbit

  • Documentation
    • Updated feedback guide URL in pull request template to reference the current version.

@coderabbitai

coderabbitai Bot commented Apr 2, 2026 •

Copy link
Copy Markdown
Contributor

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: bdfdcaf4-ee38-4f1e-9095-d581a3e2a385

📥 Commits

Reviewing files that changed from the base of the PR and between bc54dfa and 548d4f7.

📒 Files selected for processing (1)
  • .github/pull_request_template.md

Walkthrough

The pull request template URL for the v3 feedback guide is updated from the alpha documentation path (v3alpha.wails.io/getting-started/feedback/) to the current production path (v3.wails.io/feedback/).

Changes

PR Template Update

Layer / File(s) Summary
Documentation
.github/pull_request_template.md
Feedback guide link updated from alpha docs to production docs; URL path simplified and domain corrected.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~1 minute

Suggested labels

Documentation

Suggested reviewers

  • leaanthony

Poem

🐰 A link once lost in alpha's haze,
Now shines in prod's bright, clearer gaze,
From /getting-started/ deep and long,
To /feedback/ where it all belongs! 🎯

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive The title 'Fix GitHub template' is vague and does not clearly specify what was fixed in the template or the nature of the change. Consider revising the title to be more specific, such as 'Fix feedback URL in GitHub PR template' to better convey the exact change made.
✅ Passed checks (4 passed)
Check name Status Explanation
Description check ✅ Passed The PR description references the linked issue and identifies the change as a bug fix, but lacks a detailed summary of the changes made and does not fully complete the template sections.
Linked Issues check ✅ Passed The code changes successfully address issue #5108 by updating the feedback URL in the GitHub PR template from the incorrect to the correct path.
Out of Scope Changes check ✅ Passed All changes are within scope: the PR template URL update and changelog entry are directly related to fixing issue #5108. The accidental inclusion of transport_event_ipc.go was corrected per maintainer feedback.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
Review rate limit: 7/8 reviews remaining, refill in 7 minutes and 30 seconds.

Comment @coderabbitai help to get the list of available commands and usage tips.

@leaanthony

Copy link
Copy Markdown
Member

Thanks for raising this. Did you update v3/pkg/application/transport_event_ipc.go in error?
Please could you add an entry to the changelog located at v3/UNRELEASED_CHANGELOG.md? Thanks!

@wayneforrest

Copy link
Copy Markdown
Contributor Author

Thanks @leaanthony --- yes it was a mistake to change v3/pkg/application/transport_event_ipc.go that should / is part of another PR.

@wayneforrest
wayneforrest force-pushed the fix-github-template branch from c5906c4 to f1ddafb Compare April 3, 2026 08:20
@leaanthony
leaanthony changed the base branch from v3-alpha to master April 29, 2026 13:08
@leaanthony

Copy link
Copy Markdown
Member

✅ Triaged by Wails PR Reviewer

This PR has been reviewed and accepted.

Head Ref OID: 8b3b74c7543ffac668b7ea9613322a3b333bb470


This comment serves as a signature that this PR has been triaged. Future runs will skip this PR based on the headRefOid.

@leaanthony
leaanthony merged commit 3cda678 into wailsapp:master May 2, 2026
9 of 11 checks passed
leaanthony pushed a commit to vinhvoit225/wails that referenced this pull request May 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

PR Template has wrong URL

2 participants