Skip to content

Fixed macOS window close with pending async Go-bound function call crashes #4354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
joshhardy wants to merge 3 commits into from
Closed

Fixed macOS window close with pending async Go-bound function call crashes #4354

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e725f2a
Check for destroyed window in execJS
joshhardy Jun 13, 2025
5dd8794
Add fixed macOS window close crash issue to changelog
joshhardy Jun 13, 2025
83edc4e
Merge branch 'v3-alpha' into v3-alpha-bugfix/4353_window-close-execjs…
joshhardy Jun 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions docs/src/content/docs/changelog.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,6 +128,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- Fixed system trays not showing after taskbar restarts by [@leaanthony](https://github.com/leaanthony) based on work by @kron.
- Fixed fallbackResponseWriter not implementing Flush() in [#4245](https://github.com/wailsapp/wails/pull/4245)
- Fixed fallbackResponseWriter not implementing Flush() by [@superDingda] in [#4236](https://github.com/wailsapp/wails/issues/4236)
- Fixed macOS window close with pending async Go-bound function call crashes by [@joshhardy](https://github.com/joshhardy) in [#4354](https://github.com/wailsapp/wails/pull/4354)
- Fixed Windows Efficiency mode startup race condition by [@leaanthony](https://github.com/leaanthony)

### Changed
Expand Down
2 changes: 1 addition & 1 deletion v3/pkg/application/webview_window_darwin.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1047,7 +1047,7 @@ func (w *macosWebviewWindow) execJS(js string) {
if performingShutdown {
return
}
if w.nsWindow == nil {
if w.nsWindow == nil || w.parent.isDestroyed() {
return
}
C.windowExecJS(w.nsWindow, C.CString(js))
Expand Down