fix(hooks): coerce quoted false for short_circuit / prompt_gate - #632
Merged
plind-junior merged 2 commits intoJul 30, 2026
Merged
Conversation
github-actions
Bot
added
docs
This was referenced Jul 30, 2026
plind-junior
enabled auto-merge
July 30, 2026 13:09
…hdev#631) vouchdev#620 fixed most loaders, but short_circuit_cfg and prompt_gate_cfg still used bare bool(), so enabled: "false" silently turned those features on. both now use coerce_bool. Fixes vouchdev#631
auto-merge was automatically disabled
July 30, 2026 13:21
Head branch was pushed to by a user without write access
kurosawareiji7007-hub
force-pushed
the
fix/hooks-coerce-bool-enabled
branch
from
July 30, 2026 13:21
3d6971c to
96b88a7
Compare
Contributor
|
diff coverage: n/a — this PR changes no python under |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#620/#558moved most config loaders ontocoerce_bool, butshort_circuit_cfgandprompt_gate_cfgstill used barebool().enabled: "false"therefore silently enabled short-circuit and the prompt gate on every Claude Code turn.coerce_bool(..., False).Test plan
tests/test_hooks.py::test_short_circuit_cfg_is_defensive(quoted false/true)tests/test_hooks.py::test_prompt_gate_cfg_is_defensive(quoted false/true)testFixes #631