ci(trust-gate): drop the trust gate - #630
Merged
Merged
Conversation
trust-gate.yml failed a pr when an author outside the OWNER association touched a core path. the rewritten arm-auto-merge.yml already enforces that bar from the other side: nothing arms without the owner's own label, a green `diff coverage` on that head sha, and a closing reference to an owner-opened issue. CODEOWNERS still holds the review requirement on core paths. removed with it: the `trust` pr_bot command and the `is_trusted` helper it called, plus their tests. core-path classification stays — it is what arm-auto-merge.yml reads. trust-gate is still listed in the `test` ruleset's required checks, so that entry has to come out or every pr will block on a check that no longer reports.
github-actions
Bot
added
docs
This was referenced Jul 30, 2026
plind-junior
pushed a commit
that referenced
this pull request
Jul 30, 2026
#630 removed the trust-gate workflow and the coderabbit gate removed coderabbit-approved, but setup_repo_guards.sh still declared both as required status checks. a required context with nothing behind it never reports at all, so the pr sits pending instead of failing visibly — there is no red x to point at, and every open pr into test is stuck this way right now. the required list is now the four ci contexts that actually run, and the header says why a dead context is worse than a failing one. the script matches the live ruleset by name, so re-running it updates in place and clears the stale contexts rather than creating a second ruleset.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
what
drops the
trust-gateworkflow and the pr_bot machinery behind it.why
trust-gate.ymlfailed a pr when an author outside the OWNER associationtouched a core path. the rewritten
arm-auto-merge.ymlalready enforces thatbar from the other side — nothing arms without the owner's own label, a green
diff coverageon that head sha, and a closing reference to an owner-openedissue — and CODEOWNERS still holds the review requirement on core paths. so
this removes a second, redundant expression of the same rule.
removed with it: the
trustpr_bot command and theis_trustedhelper itcalled, plus their tests. core-path classification stays, because that is what
arm-auto-merge.ymlreads.required-check follow-up
trust-gateis currently a required status check on the auto-merge guard(test) ruleset, alongside the three test legs and the build. that entry has
to be removed from the ruleset — otherwise every pr targeting
testblocks ona check that no longer reports. safest order is to drop it from the ruleset
first, then merge this.
test
pytest tests/test_pr_bot.py,mypy src,ruff check src testsall green.