fix(digest): drop archived pages from followups-due - #626
Merged
plind-junior merged 2 commits intoJul 30, 2026
Merged
Conversation
github-actions
Bot
added
docs
plind-junior
enabled auto-merge (squash)
July 30, 2026 10:36
auto-merge was automatically disabled
July 30, 2026 11:09
Head branch was pushed to by a user without write access
kurosawareiji7007-hub
force-pushed
the
fix/digest-archived-followups
branch
from
July 30, 2026 11:09
1ed6964 to
43e0261
Compare
This was referenced Jul 30, 2026
Member
|
Thanks for the contribution @kurosawareiji7007-hub . All your findings are valid and worth. Would you pick up the issues from GH issue board? |
plind-junior
enabled auto-merge
July 30, 2026 13:08
auto-merge was automatically disabled
July 30, 2026 13:19
Head branch was pushed to by a user without write access
kurosawareiji7007-hub
force-pushed
the
fix/digest-archived-followups
branch
from
July 30, 2026 13:19
c0dd843 to
c205fa4
Compare
github-actions
Bot
added
size: S
digest already skipped done/dropped followup metadata and retired claims, but an ARCHIVED page with followup_status=open and a past due_at still appeared in the morning briefing. mirror recall: archived leave the list. Fixes vouchdev#625
kurosawareiji7007-hub
force-pushed
the
fix/digest-archived-followups
branch
from
July 30, 2026 13:19
c205fa4 to
36c2270
Compare
github-actions
Bot
added
size: XS
3 tasks
plind-junior
added a commit
to kurosawareiji7007-hub/vouch
that referenced
this pull request
Jul 30, 2026
auto-merge had two arming surfaces, both requiring the owner to act: the auto-merge label and the /auto-merge comment. green ci triggered nothing, and deauthorize-on-push voids arming on every contributor push — so a PR like vouchdev#626 was armed twice and disarmed twice by force-pushes, then sat clean and green with no one left to re-arm it. add a third arming path with no human in it. on `ci` completing green for a pull request, resolve the PR from the head sha, confirm it still sits on that sha and is open and undrafted, wait for every other check run on the sha to finish, and refuse if any of them failed — `ci` is only one of the workflows a PR runs, and `test` has no branch protection to wait on the rest. the bars are unchanged. arming still goes through arm-auto-merge.yml, so full diff coverage of changed python under src/vouch/ and a closing reference to an issue plind-junior opened are both still required. the owner-issue link is read once up front here too, silently: arm-auto-merge comments when a PR misses that bar, which is right for a human who just asked to arm and would be per-push noise unattended. no checkout, no PR code — only metadata, since the arming job holds a write token. workflow_run resolves this file from the default branch, so it takes effect once it reaches main, not on merge to test.
Contributor
Author
|
Thanks — I'll pick up board issues next. Starting with #602 (capture.realtime opt-in). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
digest.buildalready skipped retired claims anddone/droppedfollowup metadata, but anARCHIVEDfollowup page withfollowup_status=openand a pastdue_atstill landed infollowups_due.PageStatus.ARCHIVEDin the followup comprehension (same live-set rule as recall).Test plan
tests/test_digest.py::test_build_excludes_archived_followupstests/test_digest.pygreentestFixes #625