fix(verify/doctor): count missing externals as failures - #623
Merged
plind-junior merged 2 commits intoJul 30, 2026
Merged
Conversation
github-actions
Bot
added
docs
plind-junior
enabled auto-merge (squash)
July 30, 2026 10:36
verify_all and doctor only treated external_status=drift as a problem, while vouch source verify already marked missing as !. deleted upstream files could leave doctor ok:true while the CLI failed. include missing in the failed set and emit a source_missing warning. Fixes vouchdev#622
auto-merge was automatically disabled
July 30, 2026 11:09
Head branch was pushed to by a user without write access
kurosawareiji7007-hub
force-pushed
the
fix/verify-missing-external
branch
from
July 30, 2026 11:09
ef930e5 to
d250260
Compare
This was referenced Jul 30, 2026
Member
|
Nice catch! Verdict approved |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
verify_allnow includesexternal_status=missingin the auditfailedset (alongsidedrift), matching CLIvouch source verify.health.doctoremits a warningsource_missingwhen an upstream file locator is gone/unreadable, so doctor can no longer reportok: truewhile the CLI fails for the same KB.Test plan
tests/test_verify.py::test_verify_all_counts_missing_external_as_failedtests/test_health.py::test_doctor_warns_on_missing_external_filetestFixes #622