Hermes needs to be disabled #153

Activity

1. kawpuh

   changed the title [-]Hermes enabled by default[/-] [+]Hermes needs to be disabled[/+] on Jul 24, 2023
2. jeisses commented on Jul 26, 2023

   

   jeisses

   on Jul 26, 2023

   More actions

   I ran into the same issue, and disabling Hermes solved it for me as well. Thanks for sharing this 👍

   When using advanced compilation it is possible to enable Hermes again
3. nsadeh commented on Jul 31, 2023

   

   nsadeh

   on Jul 31, 2023

   More actions

   It should be possible to define :language-out :es5 for the compiler so that this isn't an issue. @jeisses how do you re-enable hermes for advanced compilation? Manually?
4. jeisses commented on Jul 31, 2023

   

   jeisses

   on Jul 31, 2023

   More actions

   Yes manually, which is not great.
   I also switched to setting :language-out :es5 which is more convenient. Wonder if there are any downsides with switching to es5
5. nsadeh commented on Jul 31, 2023

   

   nsadeh

   on Jul 31, 2023 via email

   Last edited by nsadeh

   More actions

   Sorry I am new to clojurescript builds and haven’t figured out where to put that setting. I put that in build.edn but still get errors, is that the right place?
6. kawpuh commented on Aug 1, 2023

   

   kawpuh

   on Aug 1, 2023

   Last edited by kawpuh

   Author

   More actions

   At least for android, instead of manually switching you could add --extra-params=-PhermesEnabled=false to your npx react-native run-android command for debug builds. You can read more about it here. It seems to take precedence over the hermesEnabled property in gradle.properties
7. kawpuh commented on Nov 28, 2023

   

   kawpuh

   on Nov 28, 2023

   Last edited by kawpuh

   Author

   More actions

   I've seen talk of adding :language-out :es5 to build.edn as an alternative, but this doesn't seem to work for me. If anyone has an alternative work around for using hermes with krell debug builds it would be nice to know as react-native-reanimated has problems with JSC.
   EDIT:
   It seems to be an issue with re-frame-http-fx in particular. If you're not using this library you may be able to get by with just adding :language-out :es5 to build.edn and removing your target folder before recompiling.
8. hadils commented on Aug 5, 2024

   

   hadils

   on Aug 5, 2024

   Last edited by hadils

   More actions

   Ok. :language-out :es5 works not with Hermes, except for this:

    ERROR  Could not evaluate http://192.168.0.190:8081/target/goog/net/xhrio.js [TypeError: Cannot read property 'getLogger' of undefined]```
    
    This is because there are exclamation marks in the variable names in this file. How do I solve this problem?
   
9. kawpuh commented on Sep 20, 2024

   

   kawpuh

   on Sep 20, 2024

   Author

   More actions

   From the slack