Repository navigation
Conversation
Skip the readiness probe on a later deploy when workers.dev is off and no route can reach the Worker, then activate the uploaded version. Do not suggest an account subdomain in that case. Co-authored-by: sayhola <sayhola@froq.me>
Reformat the deploy reference and Cloudflare guide tables so the format check accepts them. Co-authored-by: sayhola <sayhola@froq.me>
Member
|
This looks good for Workers that are only reachable through service bindings but there are some issues: Can we limit this to Workers that we know have no HTTP routes, and keep failing otherwise? We should add regression tests for both of those patterns too. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #644
Description
Later deploys of a Worker with
workers_devoff and no route or Custom Domain now skip the readiness probe and activate the uploaded version, same as the first deploy. Whenworkers_devis on and there is no preview URL, deploy still fails and still asks forCLOUDFLARE_WORKERS_SUBDOMAIN. That subdomain hint is no longer shown whenworkers_devis off.--atomicstill refuses a Worker with no Durable Object migration history. Docs updated in the Cloudflare integration guide, deploy CLI reference, and the generated workflow comment ininit.Test
pnpm exec vp test run packages/deploy-cloudflare/test/unit/version.test.ts packages/void/test/unit/cloudflare-deploy.test.ts(713 tests)pnpm exec vp run --filter ./packages/deploy-cloudflare --filter ./packages/void typecheck